RTC a11y NPM Resource Changed bug PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
24 Jan 2026

Pull Request for Issue #43708

Summary of Changes

When using btn-classes in an alert message, the styling is not everywhere readable. This PR fixes it.

Testing Instructions

Open the index.php of the backend atum template and add the following code in line 25:

$text = 'This is a text
         <a href="#">with a link</a>
         <br><br>
         some link buttons: <a href="#" class="btn btn-primary">Primary</a> <a href="#" class="btn btn-secondary">Secondary</a> <a href="#" class="btn btn-success">Success</a> <a href="#" class="btn btn-danger">Danger</a> <a href="#" class="btn btn-warning">Warning</a> <a href="#" class="btn btn-info">Info</a> <a href="#" class="btn btn-light">Light</a> <a href="#" class="btn btn-dark">Dark</a> <a href="#" class="btn btn-link">Link</a>
         <br><br>
         normal buttons: <button type="button" class="btn btn-primary">Primary</button> <button type="button" class="btn btn-secondary">Secondary</button> <button type="button" class="btn btn-success">Success</button> <button type="button" class="btn btn-danger">Danger</button> <button type="button" class="btn btn-warning">Warning</button> <button type="button" class="btn btn-info">Info</button> <button type="button" class="btn btn-light">Light</button> <button type="button" class="btn btn-dark">Dark</button> <button type="button" class="btn btn-link">Link</button>
         ';

$app->enqueueMessage($text, 'success');
$app->enqueueMessage($text, 'info');
$app->enqueueMessage($text, 'warning');
$app->enqueueMessage($text, 'danger');

Actual result BEFORE applying this Pull Request

Light mode:
grafik

Dark mode:
grafik

Expected result AFTER applying this Pull Request

Light mode:
grafik

Dark mode:
grafik

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar bembelimen bembelimen - open - 24 Jan 2026
avatar bembelimen bembelimen - change - 24 Jan 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Jan 2026
Category Repository NPM Change
avatar brianteeman
brianteeman - comment - 24 Jan 2026

On my phone now so can't find it but I created an issue about this a long time ago so this pr should be able to close that

avatar brianteeman
brianteeman - comment - 24 Jan 2026

Found it #43708

avatar exlemor exlemor - test_item - 24 Jan 2026 - Tested successfully
avatar exlemor
exlemor - comment - 24 Jan 2026

I have tested this item ✅ successfully on 1e314c1

I have tested this PR successfully - nice catch @bembelimen!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46752.
avatar bembelimen bembelimen - change - 24 Jan 2026
The description was changed
avatar bembelimen bembelimen - edited - 24 Jan 2026
avatar chmst chmst - test_item - 24 Jan 2026 - Tested successfully
avatar chmst
chmst - comment - 24 Jan 2026

I have tested this item ✅ successfully on 1e314c1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46752.

avatar chmst chmst - change - 24 Jan 2026
Status Pending Ready to Commit
avatar chmst
chmst - comment - 24 Jan 2026

RTC - good catch!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46752.

avatar brianteeman
brianteeman - comment - 24 Jan 2026

@chmst its been an open a11y issue since Jun 26, 2024

avatar chmst
chmst - comment - 24 Jan 2026

correct. Now it is fixed

avatar richard67 richard67 - change - 25 Jan 2026
Labels Added: RTC a11y NPM Resource Changed bug PR-5.4-dev
avatar richard67 richard67 - change - 25 Jan 2026
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2026-01-25 12:47:11
Closed_By richard67
avatar richard67 richard67 - close - 25 Jan 2026
avatar richard67 richard67 - merge - 25 Jan 2026
avatar richard67
richard67 - comment - 25 Jan 2026

Thanks @bembelimen for this PR, and @chmst and @exlemor for testing.

Add a Comment

Login with GitHub to post a comment