RTC Language Change bug PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
19 Jan 2026

Summary of Changes

the template manager can open/read zip archives BUT if you dont have the php ziparchive extension enabled on your server you get ugly errors.

this PR adds a check for the ziparchive extension

I made this against 5.4 branch as its a bug fix BUT it adds a new language string so maybe that means it has to be pushed to 6.1

Testing Instructions

  1. add a zip file to \media\templates\site\cassiopeia
  2. in the template manager select the archive
  3. if you can see the contents of the archive then you have the ziparchive extension for php enabled
  4. disable the ziparchive extension for php. If you are using laragon its as simple as unchecking zip in the list
image

Actual result BEFORE applying this Pull Request

when the ziparchive extensions is disabled
image

Expected result AFTER applying this Pull Request

when the ziparchive extension is disabled
image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 19 Jan 2026
avatar brianteeman brianteeman - change - 19 Jan 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Jan 2026
Category Administration com_templates Language & Strings
avatar brianteeman brianteeman - change - 19 Jan 2026
Labels Added: Language Change PR-5.4-dev
avatar brianteeman brianteeman - change - 19 Jan 2026
Labels Added: bug
avatar heelc29 heelc29 - test_item - 21 Jan 2026 - Tested successfully
avatar heelc29
heelc29 - comment - 21 Jan 2026

I have tested this item ✅ successfully on ba1c52f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46716.

avatar PixedBo PixedBo - test_item - 23 Jan 2026 - Tested successfully
avatar PixedBo
PixedBo - comment - 23 Jan 2026

I have tested this item ✅ successfully on ba1c52f

Tested with WAMP, no problems as expected


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46716.

avatar richard67 richard67 - change - 23 Jan 2026
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 23 Jan 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46716.

avatar muhme muhme - change - 24 Jan 2026
Labels Added: RTC
avatar muhme
muhme - comment - 26 Jan 2026

✅ Final test before merge with JBT

  • Before PR, commented out extension=zip in /usr/local/etc/php/conf.d/docker-php-ext-zip.ini file and restarted Docker container, seen ugly:
    An error has occurred.
    0 Class "ZipArchive" not found 
    
  • Applied PR with Patch Tester
  • Seen proper error message 'The PHP ZipArchive extension is not enabled.'
  • Enabled zip extension again, restarted Docker container and ZIP archive content is shown in template manager
avatar muhme muhme - change - 26 Jan 2026
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2026-01-26 13:09:25
Closed_By muhme
avatar muhme muhme - close - 26 Jan 2026
avatar muhme muhme - merge - 26 Jan 2026
avatar muhme
muhme - comment - 26 Jan 2026

Thank you @brianteeman for your contribution. Thank you @sandewt for support and @heelc29 and @PixedBo for testing.

avatar brianteeman
brianteeman - comment - 26 Jan 2026

Thanks

Add a Comment

Login with GitHub to post a comment