Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#46656] - [6.1][webservices] add filter state to banners endpoint

Webservices PR-6.1-dev Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
10 Jan 2026

Pull Request for Issue # .

Summary of Changes

add filter state to banners endpoint

Testing Instructions

GET {{base_path}}/api/index.php/v1/banners?filter[state]=1
GET {{base_path}}/api/index.php/v1/banners?filter[state]=0

Actual result BEFORE applying this Pull Request

N/A

Expected result AFTER applying this Pull Request

you can filter banners from state = published or unpublished

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar alikon alikon - open - 10 Jan 2026
avatar alikon alikon - change - 10 Jan 2026
Status New ⇒ Pending
52d031d 10 Jan 2026 avatar alikon cs
avatar alikon alikon - change - 10 Jan 2026
Labels Added: Webservices PR-6.1-dev
avatar Razzo1987 Razzo1987 - test_item - 10 Jan 2026 - Tested successfully
avatar Razzo1987
Razzo1987 - comment - 10 Jan 2026

I have tested this item ✅ successfully on 52d031d

POST:

{
    "catid": 3,
    "clicks": 0,
    "custombannercode": "",
    "description": "Text",
    "metakey": "",
    "name": "Name",
    "params": {
        "alt": "",
        "height": "",
        "imageurl": "",
        "width": ""
    }
}

1 result with https://joomla.sviluppo.online/api/index.php/v1/banners?filter%5Bstate%5D=0&page%5Blimit%5D=20&page%5Boffset%5D=0

0 result with https://joomla.sviluppo.online/api/index.php/v1/banners?filter%5Bstate%5D=1&page%5Blimit%5D=20&page%5Boffset%5D=0

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46656.
avatar joomla-cms-bot joomla-cms-bot - change - 10 Jan 2026
Category ⇒ JavaScript Unit Tests
avatar exlemor
exlemor - comment - 29 Jan 2026

@alikon - I am trying to test this during PBF and in the BEFORE condition, when I do a GET:

https://master222.pbf20.org/api/index.php/v1/banners?filter[state]=1

I get a 200 OK,

{
"links": {
"self": "https://master222.pbf20.org/api/index.php/v1/banners?filter[state]=0"
},
"data": [],
"meta": {
"total-pages": 0
}
}

Am I misunderstanding but shouldn't I get a 404 or 500 since the functionality shouldn't exist BEFORE THE PR?

avatar crimle crimle - test_item - 30 Jan 2026 - Tested successfully
avatar crimle
crimle - comment - 30 Jan 2026

I have tested this item ✅ successfully on 77f36f2

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46656.

avatar alikon
alikon - comment - 31 Jan 2026

@exlemor in the before scenario the filter doesn't exists so it's ignored that's why you get 200 it's like you are going
GET {{base_path}}/api/index.php/v1/banners

avatar Razzo1987 Razzo1987 - test_item - 31 Jan 2026 - Tested successfully
avatar Razzo1987
Razzo1987 - comment - 31 Jan 2026

I have tested this item ✅ successfully on 77f36f2

Re-test successfully ;)

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46656.

avatar rbuelund rbuelund - test_item - 31 Jan 2026 - Tested successfully
avatar rbuelund
rbuelund - comment - 31 Jan 2026

I have tested this item ✅ successfully on 77f36f2

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46656.

avatar tecpromotion tecpromotion - change - 31 Jan 2026
Status Pending ⇒ Ready to Commit
avatar tecpromotion
tecpromotion - comment - 31 Jan 2026

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46656.

avatar hamby
hamby - comment - 31 Jan 2026

Successful test with the expected result.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46656.

Add a Comment

Login with GitHub to post a comment