RTC bug PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
27 Dec 2025

Pull Request for Issue #46582 .

Summary of Changes

If a user defines an own image-class for intro_image or full_image, it is now set before the module classes.

Testing Instruction

see #46582
In an article, add a into or full-image and add an image-class, for example "border border-dark".
Make a module mod_articles where this article is included. Then inspect the code of the image in this module.

Actual result BEFORE applying this Pull Request

The user defined image-class "border border-dark" is ignored.

Expected result AFTER applying this Pull Request

Example:
grafik

The user defined image-class "border border-dark" is accepted.

grafik

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar chmst chmst - open - 27 Dec 2025
avatar chmst chmst - change - 27 Dec 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Dec 2025
Category Modules Front End
avatar chmst chmst - change - 27 Dec 2025
Title
[5.] Accept user input in image class.
[5.4] Accept user input in image class.
avatar chmst chmst - edited - 27 Dec 2025
avatar exlemor
exlemor - comment - 27 Dec 2025

Hi @chmst, I could be doing something wrong but I'm not matching the BEFORE condition (or I misunderstood it)

I took a sample multilingual joomla 5.4 nightly installation and added to 'Article (en-gb)' the Banners Sky image as Intro image and set the class 'border border-dark', saved and added to the user.css this css rule: .border.border-dark {width:50%;} and then went to the front-end (cleared cache) and the CSS was accepted/handled, the image is 50% width... what did I miss?

avatar brianteeman
brianteeman - comment - 27 Dec 2025

@exlemor display the article in the article module

avatar chmst
chmst - comment - 27 Dec 2025

@exlemor sorry, my test instruction needs an enhancment

avatar exlemor exlemor - test_item - 27 Dec 2025 - Tested successfully
avatar exlemor
exlemor - comment - 27 Dec 2025

I have tested this item ✅ successfully on 2b45a68

I have successfully tested this PR - helps when you don't miss a step (thanks @brianteeman).

THANK YOU @chmst for yet another fix ;) Happy Holidays!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46619.

avatar chmst chmst - change - 27 Dec 2025
The description was changed
avatar chmst chmst - edited - 27 Dec 2025
avatar tecpromotion tecpromotion - test_item - 30 Dec 2025 - Tested successfully
avatar tecpromotion
tecpromotion - comment - 30 Dec 2025

I have tested this item ✅ successfully on 2b45a68


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46619.

avatar tecpromotion tecpromotion - change - 30 Dec 2025
Status Pending Ready to Commit
Labels Added: bug PR-5.4-dev
avatar tecpromotion
tecpromotion - comment - 30 Dec 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46619.

avatar muhme muhme - change - 8 Jan 2026
Labels Added: RTC
avatar muhme
muhme - comment - 8 Jan 2026

✅ Final test before merge with JBT

  • Seen the problem before PR, article view displays custom image class settings for intro and full image, but not in Articles module
  • Applied PR with gh pr checkout 46619
  • Intro and full images are shown with custom image class settings in Articles module
avatar muhme muhme - close - 8 Jan 2026
avatar muhme muhme - merge - 8 Jan 2026
avatar muhme muhme - change - 8 Jan 2026
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2026-01-08 13:12:52
Closed_By muhme
avatar muhme
muhme - comment - 8 Jan 2026

Thank you @chmst for your contribution. Thank you @brianteeman for support. Thank you @exlemor and @tecpromotion for testing.

Add a Comment

Login with GitHub to post a comment