RTC NPM Resource Changed bug PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
13 Dec 2025

Summary of Changes

Several conditions must be met for this error to occur (see also testing instructions).

Here are the details:

  1. The point when Joomla 6 is mentioned must be reached (2 months after release) -> this is when the quickicon eos becomes active
  2. A message from a different message category must be displayed. In this case, it's the notification that the PHP version has switched to security mode -> this results in two messages being added to the document at the same time
  3. The message for statistics must be displayed

To fix snooze button is not working for point 2: its necessary to replace the return with continue so that the complete mutationList (for loop) is checked

To fix the javascript error for point 3: its necessary to check the node for Node.ELEMENT_NODE before querySelector because the statistic message renders also a #text element with an empty line "\n" which case the java script error

I hope that's understandable.

Testing Instructions

You need J5.4 with PHP 8.1 and message for Joomla Statistics
image

Actual result BEFORE applying this Pull Request

  • snooze button is not working

  • javascript error (see also current system tests failing for 5.4-dev)

image

Expected result AFTER applying this Pull Request

  • snooze button is working

  • no javascript error

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar heelc29 heelc29 - open - 13 Dec 2025
avatar heelc29 heelc29 - change - 13 Dec 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Dec 2025
Category JavaScript Repository NPM Change
avatar muhme muhme - test_item - 13 Dec 2025 - Tested successfully
avatar muhme
muhme - comment - 13 Dec 2025

I have tested this item ✅ successfully on 7d054ce

Tested with JBT on Intel macOS and PHP 8.1

  • System Test installation fails in using chrome with o.querySelector is not a function
  • Installed from the complete PR package and the system test installation step was successfully completed

Tested with JBT (hacked for chromium) on Apple-silicon and PHP 8.1

  • System Test installation fails in using chromium with o.querySelector is not a function
  • Installed from the complete PR package and the system test installation step was successfully completed

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46573.
avatar richard67 richard67 - test_item - 13 Dec 2025 - Tested successfully
avatar richard67
richard67 - comment - 13 Dec 2025

I have tested this item ✅ successfully on 7d054ce


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46573.

avatar richard67 richard67 - change - 13 Dec 2025
Status Pending Ready to Commit
Labels Added: NPM Resource Changed bug PR-5.4-dev
avatar richard67
richard67 - comment - 13 Dec 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46573.

avatar muhme muhme - change - 13 Dec 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-12-13 18:32:42
Closed_By muhme
Labels Added: RTC
avatar muhme muhme - close - 13 Dec 2025
avatar muhme muhme - merge - 13 Dec 2025
avatar muhme
muhme - comment - 13 Dec 2025

Thank you @heelc29 for your contribution. Thank you @richard67 for testing.

avatar exlemor
exlemor - comment - 13 Dec 2025

Tested it but it merged 1-2 seconds after I pressed my Successful button :/ no fair lol lol

Add a Comment

Login with GitHub to post a comment