RTC Language Change NPM Resource Changed PBF PR-6.1-dev Failure

User tests: Successful: Unsuccessful:

avatar beni71
beni71
26 Nov 2025

This pull request is a recreation of #41927, where I accidentally deleted all the code changes.

Pull Request for Issue #23304, only partially.
This PR is based on #38583 and fixes the comments.

Summary of Changes

Adds the ability to batch copy/move tags in the tags list.
Copying a tag also copies its children (same behavior as in other tree models like categories, menues).
Moving a tag also moves its children (same behavior as in other tree models like categories, menues).
For example, it is possible to move a child tag from one parent to another (including its children), or to copy a child tag from one parent to another (including its children).
In the batch tag drop down there is also an item "Root" to move/copy selected tags to the root level.

Changed visualization "Action to Perform" of copy/move action, it is now hidden as long as the user does not touch the select field for copy/move. See example in video below. This change affects batch copy/move dialog of menues and articles as well.

It also fixes a browser console error when the batch dialog is opened and cancel is clicked, on systems where multilingual is disabled.

Testing Instructions

It contains an updated javascript so run: npm run build:js

Initial tag structure for each of the tests below:
Tag1
-Tag2
--Tag3
Tag4

Test 1
Move Tag2 to Tag4 results in:
Tag1
Tag4
-Tag2
--Tag3

Test 2
Move Tag1 to Tag4 results in:
Tag4
-Tag1
--Tag2
---Tag3

Test 3
Copy Tag4 to Tag2 result in:
Tag1
-Tag2
--Tag3
--Tag4 (2)
Tag4

Test 4
Check whether the visualization of "Action to Perform" of copy/move action is first hidden for views like menues, articles. Only if a target item is selected "Action to Perform" appears.

Actual result BEFORE applying this Pull Request

The tags list batch processing does not support copy move.

Expected result AFTER applying this Pull Request

The tags list batch processing supports copy move:

tag-copy-move

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar beni71 beni71 - open - 26 Nov 2025
avatar beni71 beni71 - change - 26 Nov 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Nov 2025
Category Administration com_categories com_menus com_tags Language & Strings JavaScript Repository NPM Change
avatar beni71 beni71 - change - 26 Nov 2025
Labels Added: Language Change NPM Resource Changed PR-6.1-dev
avatar ceford ceford - test_item - 3 Jan 2026 - Tested successfully
avatar ceford
ceford - comment - 3 Jan 2026

I have tested this item ✅ successfully on dc15bd2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46501.

avatar ThomasFinnern ThomasFinnern - test_item - 9 Jan 2026 - Tested successfully
avatar ThomasFinnern
ThomasFinnern - comment - 9 Jan 2026

I have tested this item ✅ successfully on dc15bd2

Did test like the testing instructions recommended
Moving and ordering as expected


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46501.

avatar richard67 richard67 - change - 9 Jan 2026
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 9 Jan 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46501.

avatar chmst chmst - change - 25 Jan 2026
Labels Added: RTC
avatar chmst chmst - alter_testresult - 25 Jan 2026 - ceford: Tested successfully
avatar chmst chmst - alter_testresult - 25 Jan 2026 - ThomasFinnern: Tested successfully
avatar exlemor exlemor - test_item - 31 Jan 2026 - Tested unsuccessfully
avatar exlemor
exlemor - comment - 31 Jan 2026

I have tested this item 🔴 unsuccessfully on 4e6d660

Hi @beni71, sadly, I was unable to successfully fully test this. I was testing during PBF 2026 with SD watching.
I'll explain:

I downloaded the package and applied it. (due to NPM).

I set up the Initial tag structure for each of the tests below as requested:
Tag1
-Tag2
--Tag3
Tag4

I did Test 1
Move Tag2 to Tag4 results in:
Tag1
Tag4
-Tag2
--Tag3

which was successfully but when I tried to do:

Test 2
Move Tag1 to Tag4 results in:
Tag4
-Tag1
--Tag2
---Tag3

I got instead of what you showed:
Tag4
-Tag2
--Tag3
-Tag1

and just to see, I tried Test 3:

Copy Tag4 to Tag2 result in:
Tag1
-Tag2
--Tag3
--Tag4 (2)
Tag4

but (I figured this wasn't going to work), I received the warning message (orange)
Batch process failed with following error: Joomla\Component\Tags\Administrator\Table\TagTable::moveByReference() is trying to make record ID 25 a child of itself.
(I thought it was going to be a circular reference and I think that's what the above message means.

Sorry, I tried it twice. :/


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46501.

avatar beni71
beni71 - comment - 1 Feb 2026

@exlemor Anyway, thanks for testing it. Could it be that you did not reset the tag structure to the initial structure, before testing test 2 and also before test 3? It certainly looks that way. I'm pretty sure this will be successful.

Before testing Test 1, 2 and 3, the tag structure must be set back to:
Tag1
-Tag2
--Tag3
Tag4

To test 3: I don't know why an error in "moveByReference" had happened, because test 3 is a "Copy" tag test, it should not move, it should copy. Didn't you "Copy"? Could you please post your initial tag structure for test3?

avatar exlemor
exlemor - comment - 1 Feb 2026

@exlemor Anyway, thanks for testing it. Could it be that you did not reset the tag structure to the initial structure, before testing test 2 and also before test 3? It certainly looks that way. I'm pretty sure this will be successful.

Before testing Test 1, 2 and 3, the tag structure must be set back to: Tag1 -Tag2 --Tag3 Tag4

To test 3: I don't know why an error in "moveByReference" had happened, because test 3 is a "Copy" tag test, it should not move, it should copy. Didn't you "Copy"? Could you please post your initial tag structure for test3?

Hi @beni71, ok so that moveByReference is my fault because I didn't see Copy (my brain saw Move, move move move duh on me)...

As for the Test 2 failing because it had to be reset to initial structure, neither Olivier nor I understood that from the Testing Instructions but now that I see this phrase in your reply that is clear/makes ALL the difference:

Before testing Test 1, 2 and 3, the tag structure must be set back to: Tag1 -Tag2 --Tag3 Tag4

I will re-test based on that! Thank you 🥰 !

avatar tecpromotion tecpromotion - close - 11 Feb 2026
avatar tecpromotion tecpromotion - merge - 11 Feb 2026
avatar tecpromotion tecpromotion - change - 11 Feb 2026
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2026-02-11 13:47:27
Closed_By tecpromotion
Labels Added: PBF
avatar tecpromotion
tecpromotion - comment - 11 Feb 2026

Thanks @beni71 and all testers

Add a Comment

Login with GitHub to post a comment