[#46454] - [5.4] Passwort reset request: fix legend
- Ready to Commit
- Medium
- Build: 5.4-dev
- # 46454
- Diff
- chmst:54-user-reset-request-label
User tests: Successful: Unsuccessful:
Pull Request for Issue #46446 .
Replaces #46451
Summary of Changes
This PR sepaprates Legend of the fieldset and label of a field in all pages for password reset. (request, confirm, complete)
Testing Instructions
I a frontend login form click the "forgot password" link.
Actual result BEFORE applying this Pull Request
The label of the fieldset is used for a legend. If there is no label, there would not be a legend at all, which is an a11y issue.
A legend is not an instruction but summarises the content of a fieldset.
This PR adds a legend for the fieldset, if there is a label or not.
### Expected result AFTER applying this Pull Request
Note:
If this is accepted, same change is needed for similiar pages in the users component.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_users |
| Labels |
Added:
a11y
bug
PR-5.4-dev
|
||
I have tested this item ✅ successfully on 0510135
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46454.
I have tested this item ✅ successfully on 0510135
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46454.
| Labels |
Added:
RMDQ
|
||
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46454.
| Labels |
Added:
RTC
|
||
@HLeithner Seems to be a misunderstanding. A fieldset MUST have a legend whether there is a fieldset label or not.
See my text in "Actual result BEFORE applying this Pull Request"
Not in the HTML standard and I'm pretty sure an empty legend field doesn't help anyone.
https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/fieldset
In my PR I wanted to make sure that there is a legend, whether it is in the xml or not.
With your suggestion we have the same situation as before. If there is no legend defined in the xml, there is no legend at all.
Same can you do at:
https://github.com/joomla/joomla-cms/blob/5.4.0/components/com_users/tmpl/remind/default.php#L35-L37
https://github.com/joomla/joomla-cms/blob/5.4.0/components/com_users/forms/remind.xml#L7
for the Login reminder page.