PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
17 Nov 2025

Pull Request for Issue # .

Alternative to PR #46449 .

Summary of Changes

This pull request (PR) reverts PR #46081 , which has been merged before 5.4.1-rc1 and so is part of that pre-release, but not has been released yet with a stable release.

The PR was classified as bug fix as its associated issue #43969 was classified as bug, but that was possibly wrong.

Looking deeper into it, I meanwhile think it is a new feature and so should have been made for 6.1-dev.

When I had set RTC for the PR, I was not aware of it, so it is partly my mistake.

The PR has some issues which would be fixed with PR #46449 , but it still doesn't result in an ideal solution, e.g. it still needs to access the input in the model, see the review discussion in that PR.

So the clean way would be to revert PR #46081 before 5.4.1 stable, re-open issue #43969 and change that from bug to feature and implement a better solution for 6.1-dev.

For the revert part I have created this PR here.

Testing Instructions

  1. Go to "Administrator → Components → Smart Search → Filters".
  2. Create a new filter if none exists yet.
  3. Select a filter to edit.
  4. Use "Save as Copy".
  5. Go back to the list view.
  6. Check if the alias is shown in the Search Filter list.

Actual result BEFORE applying this Pull Request

A new filter is created with new title and alias.

The alias is shown in the Search Filter list.

Expected result AFTER applying this Pull Request

An error alert "Save failed with the following error: Another Filter has the same alias." is shown.

The alias is not shown in the Search Filter list.

This is the same behaviour as with 5.4.0 or previous versions.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar richard67 richard67 - open - 17 Nov 2025
avatar richard67 richard67 - change - 17 Nov 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Nov 2025
Category Administration com_finder
avatar ceford ceford - test_item - 17 Nov 2025 - Tested successfully
avatar ceford
ceford - comment - 17 Nov 2025

I have tested this item ✅ successfully on 7e64d49

Without the patch the alias is shown in the Search Filter list. With the patch it is not shown. It could be useful to show the alias in either case.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46453.

avatar richard67
richard67 - comment - 17 Nov 2025

Without the patch the alias is shown in the Search Filter list. With the patch it is not shown. It could be useful to show the alias in either case.

@ceford Yes, that should be part of the solution for 6.1.

P.S.: I've updated the testing instructions to show that change, too.

avatar richard67 richard67 - change - 17 Nov 2025
The description was changed
avatar richard67 richard67 - edited - 17 Nov 2025
avatar muhme muhme - test_item - 18 Nov 2025 - Tested successfully
avatar muhme
muhme - comment - 18 Nov 2025

I have tested this item ✅ successfully on 7e64d49

Tested with JBT and applied PR with Patch Tester

avatar muhme muhme - change - 18 Nov 2025
Labels Added: PR-5.4-dev
avatar muhme muhme - change - 18 Nov 2025
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-11-18 10:34:07
Closed_By muhme
avatar muhme muhme - close - 18 Nov 2025
avatar muhme muhme - merge - 18 Nov 2025
avatar muhme
muhme - comment - 18 Nov 2025

Thank you @richard67 for this PR. Thank you @ceford for testing.

Add a Comment

Login with GitHub to post a comment