User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Alternative to PR #46449 .
This pull request (PR) reverts PR #46081 , which has been merged before 5.4.1-rc1 and so is part of that pre-release, but not has been released yet with a stable release.
The PR was classified as bug fix as its associated issue #43969 was classified as bug, but that was possibly wrong.
Looking deeper into it, I meanwhile think it is a new feature and so should have been made for 6.1-dev.
When I had set RTC for the PR, I was not aware of it, so it is partly my mistake.
The PR has some issues which would be fixed with PR #46449 , but it still doesn't result in an ideal solution, e.g. it still needs to access the input in the model, see the review discussion in that PR.
So the clean way would be to revert PR #46081 before 5.4.1 stable, re-open issue #43969 and change that from bug to feature and implement a better solution for 6.1-dev.
For the revert part I have created this PR here.
A new filter is created with new title and alias.
The alias is shown in the Search Filter list.
An error alert "Save failed with the following error: Another Filter has the same alias." is shown.
The alias is not shown in the Search Filter list.
This is the same behaviour as with 5.4.0 or previous versions.
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | Administration com_finder |
Without the patch the alias is shown in the Search Filter list. With the patch it is not shown. It could be useful to show the alias in either case.
@ceford Yes, that should be part of the solution for 6.1.
P.S.: I've updated the testing instructions to show that change, too.
I have tested this item ✅ successfully on 7e64d49
Tested with JBT and applied PR with Patch Tester
| Labels |
Added:
PR-5.4-dev
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-11-18 10:34:07 |
| Closed_By | ⇒ | muhme |
Thank you @richard67 for this PR. Thank you @ceford for testing.
I have tested this item ✅ successfully on 7e64d49
Without the patch the alias is shown in the Search Filter list. With the patch it is not shown. It could be useful to show the alias in either case.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46453.