[#46403] - [5.4] Fix issues in language installer
- Ready to Commit
- Medium
- Build: 5.4-dev
- # 46403
- Diff
- bembelimen:5.4/installation-last-step
User tests: Successful: Unsuccessful:
Summary of Changes
When installing a language during installing Joomla! there are two issues:
- the new "Automated Updates" box does not disappear when switching to the language installer
- when the language installation is started, it seems like Joomla! is stuck, but it just installs the languages and then shows the joomla loader
This PR fixes the issues
Testing Instructions
- Apply patch
- Install Joomla!
- Install aftwards before deleting the installation folder install some languages
Actual result BEFORE applying this Pull Request
Automated Updates box visible:
No Joomla Loader:
Expected result AFTER applying this Pull Request
No Automated Updates box:
Joomla Loader directly visible when pressing "Install Selected Language":
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Installation |
I have tested this item ✅ successfully on 79c410a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46403.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-5.4-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46403.
For the "automated update" box, I have already created a PR #46275 to address this issue.
In your PR the check is missing if the element exists. This can happen if you disable the updates, then switch to languages and skip the installation. This will result in a javascript error.
| Labels |
Added:
RTC
bug
|
||
For the "automated update" box, I have already created a PR #46275 to address this issue. In your PR the check is missing if the element exists. This can happen if you disable the updates, then switch to languages and skip the installation. This will result in a javascript error.
Good point, it was worse, the box was always visible, although the automated updates were disabled, after refreshing the page. It's not fixed.
| Status | Ready to Commit | ⇒ | Pending |
Reset to ‘Pending’ because there were changes to the code. @chmst and @tecpromotion, could you please test this PR again?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46403.
I have tested this item ✅ successfully on b3e7ed8
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46403.
I have tested this item ✅ successfully on b3e7ed8
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46403.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46403.
I have tested this item ✅ successfully on 79c410a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46403.