Feature RTC Language Change PR-6.1-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
29 Oct 2025

Pull Request for Issue #44292 .

Summary of Changes

Some of the logTasks are translated and some are hard coded.

Testing Instructions

Code review

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 29 Oct 2025
avatar brianteeman brianteeman - change - 29 Oct 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Oct 2025
Category Administration Language & Strings Front End Plugins
avatar brianteeman brianteeman - change - 29 Oct 2025
Title
[6.1] LogTask not translated
[6.0] LogTask not translated
avatar brianteeman brianteeman - edited - 29 Oct 2025
avatar richard67
richard67 - comment - 29 Oct 2025

Not sure if this should be in 6.0 or 6.1

@brianteeman If it's a bug which affects both 5.4 and 6.0, it should be made for 5.4-dev, and if it's a bug which affects only 6.x it should be made for 6.0-dev, and if it counts as a new feature it should be made for 6.1-dev.

The referred issue was flagged as bug.

If you want I can ask maintainers for opinions regarding feature or not.

avatar brianteeman
brianteeman - comment - 29 Oct 2025

The new language strings mean it's not something for a patch release afaik

avatar richard67
richard67 - comment - 29 Oct 2025

The new language strings mean it's not something for a patch release afaik

@brianteeman Yes, that could be, and that would mean it's for 6.1-dev. I will clarify and let you know the result. If it is good for a patch release it also can be done for 5.4-dev.

avatar brianteeman
brianteeman - comment - 29 Oct 2025

btw i did try to rebase to 6.1 but it looks like 6.1 is a long way behind 6.0 at the moment so will leave it here for now

avatar brianteeman brianteeman - change - 29 Oct 2025
Labels Added: Language Change PR-6.0-dev
avatar richard67
richard67 - comment - 29 Oct 2025

@brianteeman The maintainer team has discussed and agreed that it should be made for 6.1-dev. After the next upmerge from 6.0-dev to 6.1-dev rebasing will be better. A clean rebase will not require new tests if the PR got some human tests in the meantime.

avatar tecpromotion
tecpromotion - comment - 30 Oct 2025

@brianteeman The maintainer team has discussed and agreed that it should be made for 6.1-dev. After the next upmerge from 6.0-dev to 6.1-dev rebasing will be better. A clean rebase will not require new tests if the PR got some human tests in the meantime.

Upmerge done (thanks @richard67 ) with PR #46384

avatar richard67
richard67 - comment - 30 Oct 2025

@tecpromotion I guess you mean „done“ and not „down“.

avatar brianteeman brianteeman - change - 30 Oct 2025
Title
[6.0] LogTask not translated
[6.1] LogTask not translated
avatar brianteeman brianteeman - edited - 30 Oct 2025
avatar brianteeman brianteeman - change - 30 Oct 2025
The description was changed
avatar brianteeman brianteeman - edited - 30 Oct 2025
avatar brianteeman
brianteeman - comment - 30 Oct 2025

Rebased to 6.1

avatar tecpromotion
tecpromotion - comment - 31 Oct 2025
#<?php die('Forbidden.'); ?>
#Date: 2025-10-31 13:27:11 UTC
#Software: Joomla! 6.0.1-dev+pr.46375 Development [ Kuimarisha ] 14-October-2025 16:01 UTC

#Fields: date	time	priority	message
2025-10-31	13:27:11	INFO	Task> Delete Logs after 1 days
2025-10-31	13:27:11	INFO	Task> Delete Logs end

If you set it to 1 day, it still says days. But that was already the case before.

avatar tecpromotion tecpromotion - test_item - 31 Oct 2025 - Tested successfully
avatar tecpromotion
tecpromotion - comment - 31 Oct 2025

I have tested this item ✅ successfully on 389e4e8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46375.

avatar alikon alikon - test_item - 2 Nov 2025 - Tested successfully
avatar alikon
alikon - comment - 2 Nov 2025

I have tested this item ✅ successfully on 389e4e8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46375.

avatar alikon alikon - change - 2 Nov 2025
Status Pending Ready to Commit
Build 6.0-dev 6.1-dev
avatar alikon
alikon - comment - 2 Nov 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46375.

avatar richard67 richard67 - change - 3 Nov 2025
Labels Added: RTC PR-6.1-dev
Removed: PR-6.0-dev
avatar tecpromotion tecpromotion - change - 3 Nov 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-11-03 17:09:02
Closed_By tecpromotion
Labels Added: Feature
avatar tecpromotion tecpromotion - close - 3 Nov 2025
avatar tecpromotion tecpromotion - merge - 3 Nov 2025
avatar tecpromotion
tecpromotion - comment - 3 Nov 2025

Thanks @brianteeman

avatar brianteeman
brianteeman - comment - 3 Nov 2025

Thanks

Add a Comment

Login with GitHub to post a comment