Unit/System Tests PR-6.0-dev Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
28 Oct 2025

Pull Request for Issue #46371 & #46334 .

Summary of Changes

This reverts PR #37140 as due update of choices #46133 the value for single space is now handle differently.

In J5.4 the parameter featured_categories is saved as string(0) "" and in J6.0 the parameter is saved as string(1) " "

Here is the relevant code for set the filter filter.frontpage.categories

J5.4: var_dump((bool) ''); -> filter not set when "All Categories" selected
bool(false)

J6.0: var_dump((bool) ' '); -> filter is set when "All Categories" selected
bool(true)

// Check for category selection
if ($params->get('featured_categories') && implode(',', $params->get('featured_categories'))) {
$featuredCategories = $params->get('featured_categories');
$this->setState('filter.frontpage.categories', $featuredCategories);
}

Testing Instructions

create menu item Featured Articles and set filter Select Categories to All Categories
visit menuitem in frontend
see also issue #46371 for more information

additional check if issue #33556 still solved

Actual result BEFORE applying this Pull Request

no featured articles are displayed

Expected result AFTER applying this Pull Request

featured articles are displayed

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar heelc29 heelc29 - open - 28 Oct 2025
avatar heelc29 heelc29 - change - 28 Oct 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Oct 2025
Category Front End com_content
avatar brianteeman
brianteeman - comment - 28 Oct 2025

This change will not fix existing menu items

avatar heelc29
heelc29 - comment - 28 Oct 2025

This change will not fix existing menu items

Do you mean we need an update sql here?

Info: This only affects menu entries that were newly created or re-saved under J6.0

avatar brianteeman
brianteeman - comment - 29 Oct 2025

yes it will need an update sql - otherwise you have to delete the settings and reselect "all categories" and save

avatar heelc29 heelc29 - change - 29 Oct 2025
Labels Added: PR-6.0-dev
avatar joomla-cms-bot joomla-cms-bot - change - 29 Oct 2025
Category Front End com_content SQL Administration com_admin Front End com_content
avatar heelc29
heelc29 - comment - 29 Oct 2025

@richard67 Can you advise me on whether I'm on the right track with the SQL update and offer some support with PostgreSQL?

avatar richard67
richard67 - comment - 29 Oct 2025

@richard67 Can you advise me on whether I'm on the right track with the SQL update and offer some support with PostgreSQL?

@heelc29 On quick view the MySQL files doe not look wrong, but I won't have time before weekend to check deeper and do something for PostgreSQL.

avatar heelc29
heelc29 - comment - 29 Oct 2025

@heelc29 On quick view the MySQL files doe not look wrong, but I won't have time before weekend to check deeper and do something for PostgreSQL.

That's fine for me.

avatar joomla-cms-bot joomla-cms-bot - change - 1 Nov 2025
Category Front End com_content SQL Administration com_admin Repository SQL Administration com_admin Postgresql Front End com_content JavaScript Unit Tests
avatar heelc29 heelc29 - change - 1 Nov 2025
Labels Added: Unit/System Tests
avatar joomla-cms-bot joomla-cms-bot - change - 1 Nov 2025
Category Front End com_content SQL Administration com_admin Repository Postgresql JavaScript Unit Tests SQL Administration com_admin Postgresql Front End com_content
avatar heelc29 heelc29 - change - 1 Nov 2025
The description was changed
avatar heelc29 heelc29 - edited - 1 Nov 2025

Add a Comment

Login with GitHub to post a comment