RTC bug PR-6.0-dev Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
28 Oct 2025

Pull Request for Issue #46371 & #46334 .

Summary of Changes

This reverts PR #37140 as due update of choices #46133 the value for single space is now handle differently.

In J5.4 the parameter featured_categories is saved as string(0) "" and in J6.0 the parameter is saved as string(1) " "

Here is the relevant code for set the filter filter.frontpage.categories

J5.4: var_dump((bool) ''); -> filter not set when "All Categories" selected
bool(false)

J6.0: var_dump((bool) ' '); -> filter is set when "All Categories" selected
bool(true)

// Check for category selection
if ($params->get('featured_categories') && implode(',', $params->get('featured_categories'))) {
$featuredCategories = $params->get('featured_categories');
$this->setState('filter.frontpage.categories', $featuredCategories);
}

Testing Instructions

create menu item Featured Articles and set filter Select Categories to All Categories
visit menuitem in frontend
see also issue #46371 for more information

additional check if issue #33556 still solved

Actual result BEFORE applying this Pull Request

no featured articles are displayed

Expected result AFTER applying this Pull Request

featured articles are displayed

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar heelc29 heelc29 - open - 28 Oct 2025
avatar heelc29 heelc29 - change - 28 Oct 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Oct 2025
Category Front End com_content
avatar brianteeman
brianteeman - comment - 28 Oct 2025

This change will not fix existing menu items

avatar heelc29
heelc29 - comment - 28 Oct 2025

This change will not fix existing menu items

Do you mean we need an update sql here?

Info: This only affects menu entries that were newly created or re-saved under J6.0

avatar brianteeman
brianteeman - comment - 29 Oct 2025

yes it will need an update sql - otherwise you have to delete the settings and reselect "all categories" and save

avatar heelc29 heelc29 - change - 29 Oct 2025
Labels Added: PR-6.0-dev
avatar joomla-cms-bot joomla-cms-bot - change - 29 Oct 2025
Category Front End com_content SQL Administration com_admin Front End com_content
avatar heelc29
heelc29 - comment - 29 Oct 2025

@richard67 Can you advise me on whether I'm on the right track with the SQL update and offer some support with PostgreSQL?

avatar richard67
richard67 - comment - 29 Oct 2025

@richard67 Can you advise me on whether I'm on the right track with the SQL update and offer some support with PostgreSQL?

@heelc29 On quick view the MySQL files doe not look wrong, but I won't have time before weekend to check deeper and do something for PostgreSQL.

avatar heelc29
heelc29 - comment - 29 Oct 2025

@heelc29 On quick view the MySQL files doe not look wrong, but I won't have time before weekend to check deeper and do something for PostgreSQL.

That's fine for me.

avatar joomla-cms-bot joomla-cms-bot - change - 1 Nov 2025
Category Front End com_content SQL Administration com_admin Repository SQL Administration com_admin Postgresql Front End com_content JavaScript Unit Tests
avatar heelc29 heelc29 - change - 1 Nov 2025
Labels Added: Unit/System Tests
avatar joomla-cms-bot joomla-cms-bot - change - 1 Nov 2025
Category Front End com_content SQL Administration com_admin Repository Postgresql JavaScript Unit Tests SQL Administration com_admin Postgresql Front End com_content
avatar heelc29 heelc29 - change - 1 Nov 2025
The description was changed
avatar heelc29 heelc29 - edited - 1 Nov 2025
avatar ceford ceford - test_item - 5 Nov 2025 - Tested successfully
avatar ceford
ceford - comment - 5 Nov 2025

I have tested this item ✅ successfully on 3bba340


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46374.

avatar chmst chmst - test_item - 10 Nov 2025 - Tested successfully
avatar chmst
chmst - comment - 10 Nov 2025

I have tested this item ✅ successfully on 3bba340

Tested with mysql update, not postgresql


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46374.

avatar richard67
richard67 - comment - 10 Nov 2025

@ceford @chmst Have you only tested with a new installation? Or have you also tested updating with the update package created by Drone or with applying the update SQL script in phpMyAdmin?

avatar richard67
richard67 - comment - 10 Nov 2025

@alikon or @brianteeman : Could you test this one with PostgreSQL with an update from 5.4 using the update package created by Drone (or by applying the update SQL script)? That would be really appreciated.

avatar ceford
ceford - comment - 10 Nov 2025

@ceford @chmst Have you only tested with a new installation? Or have you also tested updating with the update package created by Drone or with applying the update SQL script in phpMyAdmin?

I tested with a joomla-cms clone with the Testing Sample Data installed. So No! I did not test running the updated SQL scripts.

avatar richard67
richard67 - comment - 11 Nov 2025

@alikon or @brianteeman : Could you test this one with PostgreSQL with an update from 5.4 using the update package created by Drone (or by applying the update SQL script)? That would be really appreciated.

@alikon or @brianteeman Sorry, I just see it needs to test that with an update from 6.0.0, not from 5.4.

avatar richard67 richard67 - change - 11 Nov 2025
Labels Removed: Unit/System Tests
avatar richard67 richard67 - alter_testresult - 11 Nov 2025 - ceford: Tested successfully
avatar richard67 richard67 - alter_testresult - 11 Nov 2025 - chmst: Tested successfully
avatar richard67 richard67 - test_item - 11 Nov 2025 - Tested successfully
avatar richard67
richard67 - comment - 11 Nov 2025

I have tested this item ✅ successfully on 42fd986

I've successfully verified the issue on a clean, current 6.0-dev installation with the "Featured Articles" menu item, and I've also tested the "Archived Articles" menu item, and I've updated to the patched package for this PR with live update using the custom update URL created by drone.

After the update the issue was fixed.

I've tested that with MySQL and PostgreSQL, so we can be sure both update SQL scripts are working.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46374.

avatar richard67 richard67 - change - 11 Nov 2025
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 11 Nov 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46374.

avatar Bodge-IT Bodge-IT - change - 11 Nov 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-11-11 12:55:42
Closed_By Bodge-IT
Labels Added: RTC bug
avatar Bodge-IT Bodge-IT - close - 11 Nov 2025
avatar Bodge-IT Bodge-IT - merge - 11 Nov 2025
avatar Bodge-IT
Bodge-IT - comment - 11 Nov 2025

Thanks for the fix @Heelc, good job! Thanks to testers @richard67 & @ceford @chmst for your diligience

avatar Bodge-IT
Bodge-IT - comment - 11 Nov 2025

Thanks for the fix @heelc29 , good job! Thanks to testers @richard67 & @ceford @chmst for your diligience

Add a Comment

Login with GitHub to post a comment