[#46336] - Wrong case for method \Joomla\CMS\Mail\Mail::Send()
- New
- Medium
- Build: 5.4-dev
- # 46336
Should be \Joomla\CMS\Mail\Mail::send() (as it is in both the interface \Joomla\CMS\Mail\MailerInterface::send() implemented by that class and by its parent class \PHPMailer\PHPMailer\PHPMailer::send()).
joomla-cms-bot
- | Labels |
Added:
No Code Attached Yet
|
||
As you dont say which files this refers to or even what version of Joomla its very hard for anyone to do anything about this. Do you really expect someone to search every single file in every version of Joomla?
Eeeh, well, logically, method \Joomla\CMS\Mail\Mail::Send() can be found in file libraries/CMS/Mail/Mail.php.
So, I was not talking about usages but about the method itself, However, I guess that most usages follow the interface and thus will use send(), but any IDE that does some static analysis including type inference can show you all usages on the click of a button.
As for version, it's in all versions since this class was introduced, and I leave it up to you to fix it in older but still maintained versions or not, that's project policy which I do not know about.
isHTML() versus isHtml() have also incorrect case, though it might depend on coding and naming standards what you want to use. However, this method is not in the interface and you are extending an project external class, so IMO you should follow the naming of that external class.