RTC bug PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
6 Oct 2025

Pull Request for Issue # .

Summary of Changes

Fix return type for App getDocument() and getLanguage() methods.

Note: These objects are not initialized in the Application constructor but at different stage of Application execution and so cannot be always available.

I not sure where this PR should go, made to 5.4 for now.

Testing Instructions

Code review

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed
avatar Fedik Fedik - open - 6 Oct 2025
avatar Fedik Fedik - change - 6 Oct 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Oct 2025
Category Libraries
avatar Fedik Fedik - change - 6 Oct 2025
The description was changed
avatar Fedik Fedik - edited - 6 Oct 2025
avatar richard67 richard67 - test_item - 8 Oct 2025 - Tested successfully
avatar richard67
richard67 - comment - 8 Oct 2025

I have tested this item ✅ successfully on ff85927

Code review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46238.

avatar joomdonation joomdonation - test_item - 19 Oct 2025 - Tested successfully
avatar joomdonation
joomdonation - comment - 19 Oct 2025

I have tested this item ✅ successfully on ff85927


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46238.

avatar joomdonation joomdonation - change - 19 Oct 2025
Status Pending Ready to Commit
avatar joomdonation
joomdonation - comment - 19 Oct 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46238.

avatar richard67 richard67 - change - 19 Oct 2025
Labels Added: RTC bug PR-5.4-dev
avatar muhme muhme - change - 20 Oct 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-10-20 09:02:15
Closed_By muhme
avatar muhme muhme - close - 20 Oct 2025
avatar muhme muhme - merge - 20 Oct 2025
avatar muhme
muhme - comment - 20 Oct 2025

Thank you @Fedik for your contribution. Thank you @richard67 and @joomdonation for test by review.

avatar muhme
muhme - comment - 20 Oct 2025

✅ Final check before merge was: Code review: It only corrects the PHPDoc, no code or behaviour change

Add a Comment

Login with GitHub to post a comment