Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#46125] - [6.0] Migrate from ESLint to Biome

NPM Resource Changed PR-6.0-dev Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
19 Sep 2025

Summary of Changes

This migrates linting from ESLint to Biome, for 2 simple reasons:

  1. Performance - Biome is at least 15x faster than ESLint due to the fact it's written in Rust and it multi-threadded.
  2. Less dependencies - ESLint requires multiple plugins to work with languages and frameworks/libraries, whereas Biome supports them out of the box.

As part of this PR, I've also run the built-in formatter to try and use concise coding standards across the board.

@Fedik @dgrammatiko Would be nice to get your thoughts

avatar C-Lodder C-Lodder - open - 19 Sep 2025
avatar C-Lodder C-Lodder - change - 19 Sep 2025
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Sep 2025
Category ⇒ JavaScript Administration com_media NPM Change
avatar C-Lodder C-Lodder - change - 19 Sep 2025
Labels Added: NPM Resource Changed PR-6.0-dev
avatar joomla-cms-bot joomla-cms-bot - change - 19 Sep 2025
Category JavaScript Administration com_media NPM Change ⇒ Repository JavaScript Administration com_media NPM Change
avatar C-Lodder C-Lodder - change - 19 Sep 2025
The description was changed
avatar C-Lodder C-Lodder - edited - 19 Sep 2025
avatar laoneo
laoneo - comment - 19 Sep 2025

Did you add a line length? Would probably make sense to increase it, to have less changes in this pr.

avatar C-Lodder
C-Lodder - comment - 19 Sep 2025

@laoneo The default is 80, which I believe is the same as ESLint.

Happy to increase this if you'd like a specific value, although 80 is generally considered a good number.

avatar laoneo
laoneo - comment - 19 Sep 2025

If I remember correctly we were going in the past with 150. But can't find any evidence right now. Perhaps @wilsonge can shed some light here. Personally, I find 80 to close.

avatar laoneo
laoneo - comment - 19 Sep 2025

These here are definitely incorrect.

avatar C-Lodder
C-Lodder - comment - 26 Sep 2025

@laoneo Biome doesn't support .scss files, only .css, so shall I re-add the stylelint to cater for them?

avatar laoneo
laoneo - comment - 27 Sep 2025

Looks like then, otherwise there is a better alternative.

avatar C-Lodder C-Lodder - change - 21 Oct 2025
The description was changed
avatar C-Lodder C-Lodder - edited - 21 Oct 2025
avatar laoneo
laoneo - comment - 21 Oct 2025

There is still an issue with the line length, changes like this one look wrong to me.

avatar C-Lodder
C-Lodder - comment - 21 Oct 2025

@laoneo It wraps on a new line due to the default 80 character limit per line.

avatar C-Lodder
C-Lodder - comment - 21 Oct 2025

I've just realised that eslint isn't even being properly used. All rules were removed in (#45784) other than no-restricted-globals,

avatar laoneo
laoneo - comment - 21 Oct 2025

Nice. JS and vue files do look much better now.

Add a Comment

Login with GitHub to post a comment