[#46094] - [5.4] Remove unused variables in layouts
- Closed
- 16 Sep 2025
- Medium
- Build: 5.4-dev
- # 46094
- Diff
- joomdonation:remove_unused_variables_in_layouts
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Guess due to copy/paste errors, the variables $canCreate and $ordering are calculated but not actually be used in most of our backend management views (Banners Management, Contacts Management, Articles Management, Menu Items Management....), thus it should be removed to make code more clean and also run slightly faster :)
Testing Instructions
- Use Joomla 5.4
- Apply Patch
- Go to System -> Global Configuration, look at Server tab, set Error Reporting config option to Maximum
- Access to 2 to 3 Management pages I mentioned above, make sure it is still being displayed OK and there is no error displayed.
- Additional, if you can do code review and approve the change, that would be great.
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners com_contact com_content com_finder com_languages com_menus com_modules com_newsfeeds com_tags com_templates com_users |
Oh, so many unrelated changes after I changed the branch. So I will close this PR and redo it later.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-09-16 10:36:48 |
| Closed_By | ⇒ | joomdonation | |
| Labels |
Added:
PR-5.4-dev
|
||
| Category | Administration com_banners com_contact com_content com_finder com_languages com_menus com_modules com_newsfeeds com_tags com_templates com_users | ⇒ | Administration com_banners com_contact com_content com_fields com_finder com_joomlaupdate com_languages com_menus com_modules com_newsfeeds com_tags com_templates com_users Language & Strings |
@joomdonation Thank you for your contribution 👍 Since 5.4.0 is already in feature freeze mode, this PR needs to be moved to 6.1-dev please.