[#46093] - [6.0] Subform: add order-changed event
- Pending
- Medium
- Build: 6.0-dev
- # 46093
- Diff
- Fedik:subform-order-event
User tests: Successful: Unsuccessful:
Pull Request for Issue #45994 .
Summary of Changes
Add subform-order-changed event when order is changed in subform.
Testing Instructions
Apply patch.
Run npm install.
Add subform somewhere, example in Custom HTML module parameters:
<field type="subform" name="subform" label="Subform" multiple="true">
<form>
<field type="text" name="text" label="Text"/>
</form>
</field>Add in to index.php of Atum template:
$wa->addInlineScript('
document.addEventListener("subform-order-changed", function(event) {
console.log("fromPosition: " + event.detail.fromPosition, "toPosition: " + event.detail.toPosition);
});
', [], ['type' => 'module']);Open the form with sbform, open browser console.
Try sort the rows in subform, and check console output.
Actual result BEFORE applying this Pull Request
Console is silent
Expected result AFTER applying this Pull Request
In console a message like "fromPosition: 0, toPosition: 1"
Link to documentations
Please select:
- Documentation link for docs.joomla.org:
- No documentation changes for docs.joomla.org needed
- Pull Request link for manual.joomla.org: TBD
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
I have tested this item ✅ successfully on 08a3f52
I found the instructions difficult. As this is a single JavaScript file change the rebuild should be npm run build:js. I used a new instance of Modules: Articles to test as there are already two subforms there. I created two instances of the Test text and moved them up/down. In the Console I needed to select the Logs item to see the message (I am not too familiar with the Console). Got there in the end!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46093.
I will rebase to 6.1 when it will be in sync