[#46076] - [5.4] Add settings icon for debug plugin
- Fixed in Code Base
- 12 Sep 2025
- Medium
- Build: 5.4-dev
- # 46076
- Diff
- Denitz:patch-24
User tests: Successful: Unsuccessful:
Pull Request for Issue #45748
Summary of Changes
Add missing icon.
Testing Instructions
Apply patch, build media, enable debug, see debug bar.
Actual result BEFORE applying this Pull Request
No icon.
Expected result AFTER applying this Pull Request
See settings icon:
Link to documentations
Please select:
- No documentation changes for docs.joomla.org needed
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
PR-5.4-dev
|
||
@Denitz Please fix the code style issue reported here: https://github.com/joomla/joomla-cms/actions/runs/17666588509/job/50209353417?pr=46076
| Labels |
Added:
bug
|
||
I dont believe this is the correct fix. the debug plugin loads its own prefixed version of font awesome
@brianteeman Have you changed your mind? To me it seems that for now this fix is all we can easily do for that icon. The additional finding reported in a comment to your issue has to be investigated and possibly to be fixed with a separate PR. What do you think?
it fixes the reported bug. i still dont believe it is the correct fix #45748 (comment) but I am not going to block it
@brianteeman Would it make sense and be useful to add a "ToDo" comment to the change from this PR, telling that it shall be removed when a better solution for the fontawesome icons is found?
it would be more useful to check the entire codebase of that plugin. Its a complete mess as it was originally heavily customised from upstream but upstream has changed a lot since those customisations were made. I tried to look at it but its not a simple fix. Its not just the fontawesome thats a problem.
I have tested this item ✅ successfully on aa2110c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46076.
I have tested this item ✅ successfully on aa2110c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46076.
I have tested this item ✅ successfully on aa2110c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46076.
Nicola was faster!
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46076.
| Labels |
Added:
RTC
|
||
Final test before merge with JBT before with 5.4-dev:
- Missing icon (empty space) seen
After graft full package PR:
- ✅ Tested icon is existing and link is working in Firefox, Chrome, Safari and Edge
- ✅ Seen media/vendor/fontawesome-free/webfonts/fa-solid-900.woff2 158 kByte is already existing and loaded once
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-09-12 12:08:17 |
| Closed_By | ⇒ | muhme |
Thank you @Denitz for your contribution. Thank you @brianteeman and @richard67 for support. Thank you @richard67, @alikon and @dautrich for testing.
I dont believe this is the correct fix. the debug plugin loads its own prefixed version of font awesome