[#46075] - [6.0] Fix extensions check for updates bug
- Pending
- Medium
- Build: 5.3-dev
- # 46075
- Diff
- joomdonation:fix_check_for_updates
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
In Joomla 6, we use a single instance of ExtensionAdapter to find updates for all extensions/update sites. The latest update found for previous extension is not reset before finding update for the next extension and it causes the strange bug described in the issue #46066. Basically, if the previous extension has higher version number than the next extension, the update for the next extension could not be found.
Testing Instructions
- Use Joomla 6 (this does not happen on Joomla 5 because in Joomla 5, we create new instance of
ExtensionAdapterto find update for each extension) - Follow instructions #46066 at, confirm the issue
- Apply patch, confirm that the issue is fixed.
Would be great if @joeforjoomla and @brianteeman can test this PR because you two understand the issue already
Actual result BEFORE applying this Pull Request
- Update might not be found for certain extension
Expected result AFTER applying this Pull Request
- Update found for every extension has new version available
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository Administration com_admin SQL |
My worry is that whatever broke the code here may also have broken code elsewhere and we just havent come across it yet. I wouldnt want us to need to keep using sticking plasters
I have tested this item ✅ successfully on e10a351
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46075.
Yes it seems to work correctly by resetting the variable.
@joomdonation Could you update the phpstan-baseline.neon file? It seems PHPStan fails for your PR. It fails for parts of code not changed by your PR, no idea why. You can fix that by running ./libraries/vendor/bin/phpstan -b after having run composer install. IT will not require redo of human tests. Can you do that? Or shall I help?
@richard67 It would be great if you could help with this PR. I am not familiar with the process yet.
@joomdonation Funny: Just restarting the PHPStan GitHub action has helped. No idea why. Anyway, no need for any changes on this PR.
Thanks Richard
| Labels |
Added:
bug
PR-6.0-dev
|
||
| Category | Repository Administration com_admin SQL | ⇒ | Libraries |
I've restored the previous human test result in the issue tracker as the commit which has invalidated the test count was just an improvement of a code comment.
appears to work correctly in my limited test
I wonder why the original code was changed