Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#46028] - [6.1] house cleaning - removal deprecated helper and function

Language Change RMDQ PR-6.0-dev Pending

User tests: Successful: Unsuccessful:

avatar hans2103
hans2103
2 Sep 2025

Pull Request for Issue #46026 .

Summary of Changes

This PR will remove the deprecated helper icons.php and associated language string.
It will also remove the deprecated function print_screen in the new Helper/icons

Testing Instructions

before and after doesn't matter in this case... both removed helper and function are not used in J6 anymore and even the layout called from the non-used function print_screen in the new helper does not exist.

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar hans2103 hans2103 - open - 2 Sep 2025
avatar hans2103 hans2103 - change - 2 Sep 2025
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Sep 2025
Category ⇒ Administration com_content Front End Language & Strings
avatar hans2103 hans2103 - change - 2 Sep 2025
The description was changed
avatar hans2103 hans2103 - edited - 2 Sep 2025
avatar hans2103 hans2103 - change - 3 Sep 2025
Labels Added: Language Change PR-6.0-dev
avatar chmst
chmst - comment - 3 Sep 2025

Looks good for me. When the icon.php is removed, we have an empty folder: component/com_content/com_content.
Is this ok, @richard67?

avatar richard67
richard67 - comment - 3 Sep 2025

Looks good for me. When the icon.php is removed, we have an empty folder: component/com_content/com_content.
Is this ok, @richard67?

@chmst Sure we have an empty folder? When you remove the last file in a folder in git, the the folder is also removed. Check out the branch of this PR in a git client or check the package created by drone for this PR. There will not be that empty folder.

avatar chmst chmst - test_item - 6 Sep 2025 - Tested successfully
avatar chmst
chmst - comment - 6 Sep 2025

I have tested this item ✅ successfully on 7599f5e

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46028.

avatar laoneo
laoneo - comment - 10 Sep 2025

I would also suggest to create a class alias here to the JHtmlIcon class. Like this it will trigger only a static function call warning and not produce a fatal error that the class doesn't exist.

avatar hans2103
hans2103 - comment - 4 Oct 2025

I would also suggest to create a class alias here to the JHtmlIcon class. Like this it will trigger only a static function call warning and not produce a fatal error that the class doesn't exist.

This "bug" is out of scope for my PR.

avatar joomla-cms-bot joomla-cms-bot - change - 2 Dec 2025
Category Administration com_content Front End Language & Strings ⇒ Administration com_content Language & Strings
avatar hans2103
hans2103 - comment - 2 Dec 2025

Solved merge conflict

avatar bembelimen
bembelimen - comment - 8 Dec 2025

We can't deprecate in a bugfix version, so it has to be included in 6.1 @HLeithner & @tecpromotion

avatar HLeithner HLeithner - change - 8 Dec 2025
Title
…
[6.0] house cleaning - removal deprecated helper and function
[6.1] house cleaning - removal deprecated helper and function
avatar HLeithner HLeithner - edited - 8 Dec 2025
avatar HLeithner HLeithner - change - 8 Dec 2025
Labels Added: PR-6.1-dev
avatar hans2103 hans2103 - change - 9 Dec 2025
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2025-12-09 15:41:28
Closed_By ⇒ hans2103
Labels Added: RMDQ
Removed: PR-6.1-dev
avatar hans2103 hans2103 - close - 9 Dec 2025

Add a Comment

Login with GitHub to post a comment