[#45969] - [5.4] Show field "Show Article Images" also if introtext is truncated
- Pending
- Medium
- Build: 5.4-dev
- # 45969
- Diff
- drmenzelit:modarticle
User tests: Successful: Unsuccessful:
Pull Request for Issue #45833 .
Summary of Changes
If I remember correctly, in my first version of mod_articles I used the truncate function that removes html-tags, that is why it was necessary to display the field "Show Article Images" only if the introtext was not truncated.
That was changed in further modification of the module, but we forgot to check the field again.
Now I changed the module so the field "Show Article Images" always displays when the introtext is set to "show" no matter of the characters limit set.
Testing Instructions
Create an article with an image in text
Create an articles module, set "Introtext" to "Show", the field "Show Article Images" is displayed.
Play with the characters limit and check if article image is showing (or not).
Actual result BEFORE applying this Pull Request
The field "Show Article Images" only appears when the characters limit for the introtext is set to 0 (deactivated)
Expected result AFTER applying this Pull Request
The field "Show Article Images" is displayed when "Introtext" is set to "Show". If the article's image is inside the characters limit, it will be displayed in the module.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
Don't you think this will confuse people?
It seems people are expecting to be able to display the images inserted in text ... and at the same time truncate the introtext.
I haven't had the use case. I normally use "read more" and intro / full image on my modules.
the problem occurs when the truncating takes place and excludes the image and they think its broken
I'm with you
I normally use "read more" and intro / full image on my modules.
and would say if you want the images then either use the readmore and dont truncate or use the intro_image field
you can't please all the time
you can't please all the time
That is true...
I have tested this item ✅ successfully on 492491d
Hi Viviana, @drmenzelit - I have successfully tested this during PBF 23.08! :)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45969.
richard67
- | Title |
|
||||||
Don't you think this will confuse people?