[#45911] - [5.4] Pre-Update Check: Show correct php_minimum required version
- Fixed in Code Base
- 15 Aug 2025
- Medium
- Build: 5.4-dev
- # 45911
- Diff
- brianteeman:phpmin
User tests: Successful: Unsuccessful:
Pull Request for Issue #45907 .
Summary of Changes
To return the value of php_minimum from the updateInformation['object'], you need to access the php_minimum property correctly. Since php_minimum is a protected property of the Update object, you cannot access it directly using $updateInformation['object']->php_minimum. Instead, you need to use the get() method provided by the Update class.
So basically the code was always returning the hard coded php_minimum for the current joomla version and not getting the information for the next version in the xml
Testing Instructions
To see this you need to set the update server url to https://update.joomla.org/core/nightlies/next_major_list.xml
Code reviewers - not my code so please check it carefully
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate |
Code reviewers - not my code so please check it carefully
@brianteeman We would also check it carefully if it WAS your code 😛
I have tested this item ✅ successfully on a0a067b
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45911.
I have not tested this item.
Hmm, download failed, but without the patch it worked. Resetting my test result until I have checked if it's related or not.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45911.
| Labels |
Added:
PR-5.4-dev
|
||
I have tested this item ✅ successfully on 638a858
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45911.
I have tested this item ✅ successfully on 638a858
I have successfully tested this. :) Thanks again @brianteeman!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45911.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45911.
| Labels |
Added:
RTC
|
||
Final Test before merge, JBT recrate/php/graft
- Before this PR with 5.4-dev branch and with PHP 8.3: wrong Requirement PHP Version >= 8.1.0 is shown in Pre-Update check for Joomla 6.0
- ✅ With this PR and PHP 8.3: correct Requirement PHP Version >= 8.3.0 is shown in Pre-Update check for Joomla 6.0
- ✅ With this PR and PHP 8.1: Installation Joomla 6.0 with custom URL is not possible, correct warning 'Your PHP version "8.1.33" is lower than "8.3.0"' shown and update is not possible
Notes:
- If you use developer manual update to Joomla 6.0 with file upload, installation with PHP 8.1 is possible and ends in non-operational administrator and site with red 'Sorry, your PHP version is not supported' without any warning before
- Already before this PR and with PHP 8.1: Installation Joomla 6.0 with custom URL is not possible, correct warning 'Your PHP version "8.1.33" is lower than "8.3.0"' and update is not possible
| Title |
|
||||||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-08-15 08:18:20 |
| Closed_By | ⇒ | muhme |
Thank you @brianteeman for your contribution. Thank you @heelc29 for your support. Thank you @exlemor and @richard67 for testing.
Related #41118 and #41364