RTC PR-6.0-dev Pending

User tests: Successful: Unsuccessful:

avatar LadySolveig
LadySolveig
14 Aug 2025

Pull Request for Issue # .

Summary of Changes

This PR adds the js-grid-item-is-checked class and remove onClick in the HtmlHelper for Grid as it was originally prepared in the script.

target.querySelectorAll('.js-grid-item-is-checked').forEach((element) => element.addEventListener('click', applyIsChecked));

Additional Note:

Follow up for PR #44501 as I unfortunately messed up my branch when attempting to resolve a conflict.
Important hint from @dgrammatiko #44501 (comment)

Testing Instructions

  • install blog sample data
    BACKEND
  • go to articles list view
  • try out if you can mark single articles bei checkbox and by clicking on the row
  • try out if you can mark multiple articles
  • try out if you can select and deselect all articles
  • try if you can mark articles and use the batch processes
    FRONTEND
  1. go to Sample Layouts -> Category List
    • check if ordering works as expected
      grafik
  2. create menu item with menu item type -> List All Tags
    • check if filter works as expected
  3. create menu item with menu item type -> Featured Contacts
    • check if ordering works as expected

Install this PR
Do the same again.

Actual result BEFORE applying this Pull Request

All should work.

Expected result AFTER applying this Pull Request

All should work as before.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org: WIP

  • No documentation changes for manual.joomla.org needed

avatar LadySolveig LadySolveig - open - 14 Aug 2025
avatar LadySolveig LadySolveig - change - 14 Aug 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Aug 2025
Category Libraries
avatar brianteeman brianteeman - test_item - 15 Aug 2025 - Tested successfully
avatar brianteeman
brianteeman - comment - 15 Aug 2025

I have tested this item ✅ successfully on 77a36e1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45910.

avatar brianteeman
brianteeman - comment - 15 Aug 2025

Does this also solve #45770


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45910.

avatar dgrammatiko dgrammatiko - test_item - 15 Aug 2025 - Tested successfully
avatar dgrammatiko
dgrammatiko - comment - 15 Aug 2025

I have tested this item ✅ successfully on 77a36e1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45910.

avatar alikon alikon - change - 15 Aug 2025
Status Pending Ready to Commit
avatar alikon
alikon - comment - 15 Aug 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45910.

avatar dgrammatiko
dgrammatiko - comment - 15 Aug 2025

Does this also solve #45770

Not the onclick="Joomla.tableOrdering, these are inline scripts on another file: libraries/src/HTML/Helpers/Grid.php

avatar richard67 richard67 - change - 15 Aug 2025
Labels Added: RTC PR-6.0-dev
avatar softforge softforge - change - 16 Aug 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-08-16 10:55:35
Closed_By softforge
avatar softforge softforge - close - 16 Aug 2025
avatar softforge softforge - merge - 16 Aug 2025

Add a Comment

Login with GitHub to post a comment