[#45862] - [6.0] Views: Switch to DocumentAwareInterface everywhere
- Pending
- Medium
- Build: 6.0-dev
- # 45862
- Diff
- Hackwar:6.0-view-document
User tests: Successful: Unsuccessful:
Summary of Changes
The AbstractView::$document property is deprecated and should not be directly accessed anymore. Instead you should use AbstractView::getDocument() and AbstractView::setDocument() instead. This PR removes the last cases where AbstractView::$document was accessed directly and makes the property itself private, so that only AbstractView::getDocument() and AbstractView::setDocument() can access it anymore. This is a b/c break, which is why this is done in 6.0.
Testing Instructions
Check that the following views are still displaying correctly:
- Tracks view in Banner component in backend
- Any view of the category component, installer component joomlaupdate component and privacy component in the backend
- The MFA method and methods view and the MFA login in the user component in the backend
- Templates view of com_config in the frontend
- Any of the com_users views in the frontend, for example registration
In each case it should behave exactly identical between before and after applying the patch.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners com_categories com_installer com_joomlaupdate com_users Front End com_config Libraries |
| Labels |
Added:
b/c break
PR-6.0-dev
|
||
This is such a hard bc break which comes way too early. It should be tested extensively with all kind of 3rd party extensions.
I have tested this item ✅ successfully on 0fe42a6
I have tested this successfully. Everything seemed to work well, thanks @Hackwar.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45862.