User tests: Successful: Unsuccessful:
fix invalid json in mysql install added with #45624
postgresql is valid
I'm not sure if it's used here, because the relevant entry is normally found in #_template_styles
.
?
?
Please select:
Status | New | ⇒ | Pending |
Category | ⇒ | SQL Installation |
Hmm, possibly the parameters from the template's extension record are used when you create a new template style for that template? Just an idea.
But normally they should come from the XML I would think.
I have tested this item ✅ successfully on e8a4d36
I have tested this item ✅ successfully on e8a4d36
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
RTC
PR-6.0-dev
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-08-11 19:13:03 |
Closed_By | ⇒ | softforge |
Shouldnt there have been an update sql to fix existing installations
Shouldnt there have been an update sql to fix existing installations
@brianteeman Normally yes, but here I am not sure if that is needed.
@brianteeman The wrong json has been added 5 days ago so I never had been released.
Anyone who installed a nightly now has the invalid sql
Anyone who installed a nightly now has the invalid sql
We never granted upgrades between nightlies.
Furthermore, it is not invalid SQL, it is invalid json. It does not cause any error of which we know.
Yes, and the json used for
#_template_styles
is correct.No idea why we have these params in the extensions record for the template.
Maybe a leftover from history?
Checking that and removing them if that's the case could be out of scope of this PR.
So I tend to say it can be merged by review.