RTC PR-6.0-dev Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
6 Aug 2025

Summary of Changes

fix invalid json in mysql install added with #45624
postgresql is valid

Testing Instructions

I'm not sure if it's used here, because the relevant entry is normally found in #_template_styles.

Actual result BEFORE applying this Pull Request

?

Expected result AFTER applying this Pull Request

?

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar heelc29 heelc29 - open - 6 Aug 2025
avatar heelc29 heelc29 - change - 6 Aug 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Aug 2025
Category SQL Installation
avatar richard67
richard67 - comment - 6 Aug 2025

I'm not sure if it's used here, because the relevant entry is normally found in #_template_styles.

Yes, and the json used for #_template_styles is correct.

No idea why we have these params in the extensions record for the template.

Maybe a leftover from history?

Checking that and removing them if that's the case could be out of scope of this PR.

So I tend to say it can be merged by review.

avatar richard67
richard67 - comment - 6 Aug 2025

Hmm, possibly the parameters from the template's extension record are used when you create a new template style for that template? Just an idea.

But normally they should come from the XML I would think.

avatar QuyTon QuyTon - test_item - 7 Aug 2025 - Tested successfully
avatar QuyTon
QuyTon - comment - 7 Aug 2025

I have tested this item ✅ successfully on e8a4d36


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45855.

avatar alikon alikon - test_item - 7 Aug 2025 - Tested successfully
avatar alikon
alikon - comment - 7 Aug 2025

I have tested this item ✅ successfully on e8a4d36


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45855.

avatar alikon alikon - change - 7 Aug 2025
Status Pending Ready to Commit
avatar alikon
alikon - comment - 7 Aug 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45855.

avatar QuyTon QuyTon - change - 8 Aug 2025
Labels Added: RTC PR-6.0-dev
avatar softforge softforge - change - 11 Aug 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-08-11 19:13:03
Closed_By softforge
avatar softforge softforge - close - 11 Aug 2025
avatar softforge softforge - merge - 11 Aug 2025
avatar brianteeman
brianteeman - comment - 11 Aug 2025

Shouldnt there have been an update sql to fix existing installations

avatar richard67
richard67 - comment - 11 Aug 2025

Shouldnt there have been an update sql to fix existing installations

@brianteeman Normally yes, but here I am not sure if that is needed.

avatar richard67
richard67 - comment - 11 Aug 2025

@brianteeman The wrong json has been added 5 days ago so I never had been released.

avatar brianteeman
brianteeman - comment - 11 Aug 2025

Anyone who installed a nightly now has the invalid sql

avatar richard67
richard67 - comment - 11 Aug 2025

Anyone who installed a nightly now has the invalid sql

We never granted upgrades between nightlies.

Furthermore, it is not invalid SQL, it is invalid json. It does not cause any error of which we know.

Add a Comment

Login with GitHub to post a comment