[#45854] - [6.0] Reducing PHPStan baseline
- Pending
- Medium
- Build: 6.0-dev
- # 45854
- Diff
- Hackwar:6.0-phpstan
User tests: Successful: Unsuccessful:
Summary of Changes
PHPStan has an issue understanding the $this class in our layouts with shortened class names. This PR removes the imports and instead uses the full class name when hinting at the type of $this. This allows to reduce the baseline file considerably.
Testing Instructions
Since this is a change in docblocks, there isn't really anything to test. The passing of phpstan would be the indicator that this is working correctly.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_associations com_joomlaupdate com_users Front End Plugins |
| Labels |
Added:
PR-6.0-dev
|
||
Had the same issue with my extension, this is the only valid fix for now.
I have tested this item ✅ successfully on 06a678d
code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45854.