I think the phpstans error can be ignored here, because here is no real code changes, only comments.

I think the phpstans error can be ignored here, because here is no real code changes, only comments.

Hmm, no, they would require to change the baseline file, as the deprecation doc block comments are changed with this PR, so they cause new messages for PHPstan.

I see, so need to edit them in baseline file, okay

I see, so need to edit them in baseline file, okay

@Fedik Not edit. Just run ./libraries/vendor/bin/phpstan -b to recreate the baseline file, and ./libraries/vendor/bin/phpstan -vv to check the result (of course all after a composer install):

Hm, not sure what is wrong with phpstan, on local run it does not show the error after update of baseline file

Hm, not sure what is wrong with phpstan, on local run it does not show the error after update of baseline file

@Fedik I've just pushed a fix for that, and if that works I will also do it for your other PR.

@Fedik P.S.: WHen running PHPstan it is important that the branch is clean and up to date. Clean means there are no composer dependencies from previous runs of composer install for other branches. To be sure of that, I always do a git clean -d -x -f and then a git checkout . to get rid of any changes, then maybe a git pull to be sure the local branch is up to date with the remove, then run composer installand then you can use phpstan.

@Fedik P.P.S.: If you now check the changes om the phpstan-baseline.neon file in your PR you will see that there are no new entries, and only the version in the message has changed from 6 to 7. Maybe you can add this information to the testing instructions for reviewers.

@Fedik P.P.S.: If you now check the changes of the phpstan-baseline.neon file in your PR you will see that there are no new entries, and only the version in the message has changed from 6 to 7. Maybe you can add this information to the testing instructions for reviewers.

@richard67 thanks!
I tried on "up to date" branch, but maybe still were something missed

@Fedik Weird, for your other PR I have that problem, PHPstan work locally but fails on GitHub. Maybe something with cached results of phpstan? I will continue to check.

Final check before merge: Scrolled through file changes, including phpstan-baseline.neon

Thank you @Fedik for your contribution.

@Fedik Do you know if we need some documentation on manual.joomla.org for this PR? If so: Could you make a PR there?

Yes, I just added it for both PRs joomla/Manual#493

@Fedik Thanks. That helps me maybe also with doing it for my PR #45878 .