RTC NPM Resource Changed PR-6.0-dev Pending

User tests: Successful: Unsuccessful:

avatar hans2103
hans2103
27 Jul 2025

Pull Request for no issue

Summary of Changes

This PR for Atum template will replace all physical properties by logical properties

Testing Instructions

  • Joomla Administrator
  • view and enjoy the look and feel
  • apply PR
  • run npm run build:css
  • refresh administrator
  • view and enjoy the look and feel again
Logical property Physical property
border-block-end border-bottom
border-block-end-color border-bottom-color
border-block-end-style border-bottom-style
border-block-end-width border-bottom-width
border-block-start border-top
border-block-start-color border-top-color
border-block-start-style border-top-style
border-block-start-width border-top-width
border-inline-end border-right
border-inline-end-color border-right-color
border-inline-end-style border-right-style
border-inline-end-width border-right-width
border-inline-start border-left
border-inline-start-color border-left-color
border-inline-start-style border-left-style
border-inline-start-width border-left-width
border-start-start-radius border-top-left-radius
border-end-start-radius border-bottom-left-radius
border-start-end-radius border-top-right-radius
border-end-end-radius border-bottom-right-radius
margin-block-end margin-bottom
margin-block-start margin-top
margin-inline-end margin-right
margin-inline-start margin-left
padding-block-end padding-bottom
padding-block-start padding-top
padding-inline-end padding-right
padding-inline-start padding-left

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Atum template before and after should be the same.
No visible changes to be seen.
Only css properties have been changed from use of physical properties to use of logical properties

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar hans2103 hans2103 - open - 27 Jul 2025
avatar hans2103 hans2103 - change - 27 Jul 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Jul 2025
Category Repository Administration com_admin SQL
avatar hans2103
hans2103 - comment - 27 Jul 2025

please adjust the label 5.3-dev into 6.0-dev
my bad for choosing the wrong branch at first. :-)

avatar brianteeman
brianteeman - comment - 27 Jul 2025

when I did the first changes to logical properties there were some that were not supported by all browsers so were not changed. Have you checked all of these are now ok?

avatar brianteeman
brianteeman - comment - 27 Jul 2025

when I did the first changes to logical properties there were some that were not supported by all browsers so were not changed. Have you checked all of these are now ok?

looks ok now - great stuff

avatar hans2103
hans2103 - comment - 27 Jul 2025

when I did the first changes to logical properties there were some that were not supported by all browsers so were not changed. Have you checked all of these are now ok?

jups.. only border-radius was the last one to be converted
https://caniuse.com/?search=border-end-end-radius

avatar JeroenMoolenschot JeroenMoolenschot - test_item - 29 Jul 2025 - Tested successfully
avatar JeroenMoolenschot
JeroenMoolenschot - comment - 29 Jul 2025

I have tested this item ✅ successfully on b53a840


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45795.

avatar RickR2H RickR2H - test_item - 30 Jul 2025 - Tested successfully
avatar RickR2H
RickR2H - comment - 30 Jul 2025

I have tested this item ✅ successfully on b53a840


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45795.

avatar RickR2H RickR2H - change - 30 Jul 2025
Status Pending Ready to Commit
avatar RickR2H
RickR2H - comment - 30 Jul 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45795.

avatar rdeutz rdeutz - change - 31 Jul 2025
Labels Added: RTC PR-6.0-dev
avatar joomla-cms-bot joomla-cms-bot - change - 31 Jul 2025
Category Repository Administration com_admin SQL Repository NPM Change
avatar hans2103 hans2103 - change - 6 Aug 2025
Labels Added: NPM Resource Changed
avatar hans2103
hans2103 - comment - 6 Aug 2025

The lint error appearing is out of scope for my PR

Run npm run lint:css

> joomla@6.0.0 lint:css
> stylelint --config build/.stylelintrc.json "administrator/components/com_media/resources/**/*.scss" "administrator/templates/**/*.scss" "build/media_source/**/*.scss" "build/media_source/**/*.css" "templates/**/*.scss" "installation/template/**/*.scss"


build/media_source/templates/administrator/atum/scss/blocks/_form.scss
  212:24  ✖  Expected "0 $border-radius 0 $border-radius" to be "0 $border-radius"  shorthand-property-no-redundant-values

✖ 1 problem (1 error, 0 warnings)
  1 error potentially fixable with the "--fix" option.

Error: Process completed with exit code 2.
avatar hans2103
hans2103 - comment - 6 Aug 2025

Solved the lint issue

avatar brianteeman
brianteeman - comment - 6 Aug 2025

Solved the lint issue

weird as that should have been fixed by a previous pr to joomla 5.4 that should have been upmerged https://github.com/joomla/joomla-cms/pull/45784/files#diff-87d3122b4bf37a406319c7eadfec175e4909b2403c35730319121ebdc0be8798

avatar hans2103
hans2103 - comment - 6 Aug 2025

Solved the lint issue

weird as that should have been fixed by a previous pr to joomla 5.4 that should have been upmerged https://github.com/joomla/joomla-cms/pull/45784/files#diff-87d3122b4bf37a406319c7eadfec175e4909b2403c35730319121ebdc0be8798

I know... strange it is, but it happened and it is solved.

avatar hans2103
hans2103 - comment - 6 Aug 2025

solved merge conflict

refer to
7b78a57

avatar softforge softforge - close - 8 Aug 2025
avatar softforge softforge - merge - 8 Aug 2025
avatar softforge softforge - change - 8 Aug 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-08-08 14:34:19
Closed_By softforge
avatar softforge
softforge - comment - 8 Aug 2025

Thank you for your work and all the help from the testers

Add a Comment

Login with GitHub to post a comment