[#45795] - [6.0] Atum logical properties
- Ready to Commit
- Medium
- Build: 5.3-dev
- # 45795
- Diff
- hans2103:6.0-backend-logical-properties
User tests: Successful: Unsuccessful:
Pull Request for no issue
Summary of Changes
This PR for Atum template will replace all physical properties by logical properties
Testing Instructions
- Joomla Administrator
- view and enjoy the look and feel
- apply PR
- run
npm run build:css - refresh administrator
- view and enjoy the look and feel again
| Logical property | Physical property |
|---|---|
| border-block-end | border-bottom |
| border-block-end-color | border-bottom-color |
| border-block-end-style | border-bottom-style |
| border-block-end-width | border-bottom-width |
| border-block-start | border-top |
| border-block-start-color | border-top-color |
| border-block-start-style | border-top-style |
| border-block-start-width | border-top-width |
| border-inline-end | border-right |
| border-inline-end-color | border-right-color |
| border-inline-end-style | border-right-style |
| border-inline-end-width | border-right-width |
| border-inline-start | border-left |
| border-inline-start-color | border-left-color |
| border-inline-start-style | border-left-style |
| border-inline-start-width | border-left-width |
| border-start-start-radius | border-top-left-radius |
| border-end-start-radius | border-bottom-left-radius |
| border-start-end-radius | border-top-right-radius |
| border-end-end-radius | border-bottom-right-radius |
| margin-block-end | margin-bottom |
| margin-block-start | margin-top |
| margin-inline-end | margin-right |
| margin-inline-start | margin-left |
| padding-block-end | padding-bottom |
| padding-block-start | padding-top |
| padding-inline-end | padding-right |
| padding-inline-start | padding-left |
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Atum template before and after should be the same.
No visible changes to be seen.
Only css properties have been changed from use of physical properties to use of logical properties
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository Administration com_admin SQL |
when I did the first changes to logical properties there were some that were not supported by all browsers so were not changed. Have you checked all of these are now ok?
when I did the first changes to logical properties there were some that were not supported by all browsers so were not changed. Have you checked all of these are now ok?
looks ok now - great stuff
when I did the first changes to logical properties there were some that were not supported by all browsers so were not changed. Have you checked all of these are now ok?
jups.. only border-radius was the last one to be converted
https://caniuse.com/?search=border-end-end-radius
I have tested this item ✅ successfully on b53a840
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45795.
I have tested this item ✅ successfully on b53a840
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45795.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45795.
| Labels |
Added:
RTC
PR-6.0-dev
|
||
| Category | Repository Administration com_admin SQL | ⇒ | Repository NPM Change |
please adjust the label 5.3-dev into 6.0-dev
my bad for choosing the wrong branch at first. :-)