RTC NPM Resource Changed PR-6.0-dev Pending

User tests: Successful: Unsuccessful:

avatar hans2103
hans2103
27 Jul 2025

Pull Request for no issue.

Summary of Changes

This PR containing a CSS change add a nice open/close transition on the <details> element.
It will work in Chrome and Edge. It will not work (yet) in Safari nor Firefox and will neglect this feature.

https://nerdy.dev/open-and-close-transitions-for-the-details-element

Testing Instructions

  • Joomla Administrator > System > Global Configuration > Tab = Text Filters

  • Open and close one or all four items with a triangle before

  • Watch the transition of opening and closing

  • Apply PR

  • run npm run build:css

  • Repeat opening and closing

  • Watch the difference

Actual result BEFORE applying this Pull Request

Screen.Recording.2025-07-27.at.15.59.30.mov

Expected result AFTER applying this Pull Request

A nice transition is visible in both Crome and Edge browser
Firefox and Safari will remain as shown in "BEFORE" state and will use the nice transition once they implemented https://caniuse.com/?search=interpolate-size%3A%20allow-keywords

Screen.Recording.2025-07-27.at.15.59.02.mov

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar hans2103 hans2103 - open - 27 Jul 2025
avatar hans2103 hans2103 - change - 27 Jul 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Jul 2025
Category Repository NPM Change
avatar hans2103
hans2103 - comment - 27 Jul 2025

Merge of this PR has to wait until PR #45784 has been merged
stylelint needs to be updated first

avatar brianteeman
brianteeman - comment - 27 Jul 2025

There is a jerky motion when the details is collapsed. I set the duration to 1.2s so it can be easily seen in this video

chrome_16j1mstTDx.mp4
avatar hans2103
hans2103 - comment - 27 Jul 2025

@brianteeman I see the jerky motion and will dive into it trying to solve it.

update:
caused by:

avatar hans2103 hans2103 - change - 27 Jul 2025
Labels Added: NPM Resource Changed PR-6.0-dev
avatar hans2103
hans2103 - comment - 27 Jul 2025

@brianteeman solved issue by replacing margin-top by padding-top.

avatar brianteeman brianteeman - test_item - 27 Jul 2025 - Tested successfully
avatar brianteeman
brianteeman - comment - 27 Jul 2025

I have tested this item ✅ successfully on 7b78a57


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45794.

avatar brianteeman
brianteeman - comment - 27 Jul 2025

jerky motion is now resolved - thanks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45794.

avatar JeroenMoolenschot JeroenMoolenschot - test_item - 29 Jul 2025 - Tested successfully
avatar JeroenMoolenschot
JeroenMoolenschot - comment - 29 Jul 2025

I have tested this item ✅ successfully on 7b78a57


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45794.

avatar QuyTon QuyTon - change - 30 Jul 2025
Status Pending Ready to Commit
avatar QuyTon
QuyTon - comment - 30 Jul 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45794.

avatar Bodge-IT Bodge-IT - change - 30 Jul 2025
Labels Added: RTC
avatar rdeutz
rdeutz - comment - 30 Jul 2025

@hans2103 cloud you check the css linter messages and fix it, please.

avatar Bodge-IT
Bodge-IT - comment - 4 Aug 2025

@hans2103 There are some changes to the css lint tests coming up. can you wait until after wednesday before testing lints.

avatar richard67
richard67 - comment - 5 Aug 2025

The CSS linter (stylelint) is happy now as the composer updates have been merged up from 5.4-dev to 6.0-dev and the branch of this PR has been updated.

Update: no, there is an issue left, see my next comment.

avatar richard67
richard67 - comment - 5 Aug 2025

@hans2103 The CSS linter has one problem left after the others have disappeared after the upmerge of the updated stylelint: https://github.com/joomla/joomla-cms/actions/runs/16757973888/job/47445675587?pr=45794

Could you fix that?

avatar softforge softforge - change - 6 Aug 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-08-06 08:13:55
Closed_By softforge
avatar softforge softforge - close - 6 Aug 2025
avatar softforge softforge - merge - 6 Aug 2025
avatar softforge
softforge - comment - 6 Aug 2025

Thank you for all the hard work you put in to this and the testers for their time

Add a Comment

Login with GitHub to post a comment