[#45791] - [6.0] admin mod_latest deprecated getUser
- Closed
- 31 Jul 2025
- Medium
- Build: 6.0-dev
- # 45791
- Diff
- brianteeman:admin_mod_latest
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This PR replaces the use of the deprecated getUser with getIdentity
Testing Instructions
Create an admin module to display the latest articles
Test with the author filters
Actual result BEFORE and AFTER applying this Pull Request
identical
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration |
| Labels |
Added:
PR-6.0-dev
|
||
it could be on any version. in an ideal world when code is marked as deprecated we shouldnt be using it at that point. ie the pr that deprecates the code should also replace our own usage of the code that's what I was taught. but as that was never done we have to do it piecemeal afterwards. I made this for 6 as I can see that other uses of deprecated code in core has also been done in 6
I have not tested this item.
I have successfully tested this PR. Thanks @brianteeman :)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45791.
I have not tested this item.
I have successfully tested this PR. Thanks @brianteeman :)
@exlemor Can it be that you have forgotten to select the test result before submitting?
I have tested this item ✅ successfully on 9bd5fec
I have successfully test this as well. Thanks @brianteeman!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45791.
I have tested this item ✅ successfully on 9bd5fec
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45791.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45791.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-07-31 08:47:01 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
RTC
|
||
We have the $app in this scope available so a Factory call is not needed. See #45792 (comment) for the bigger picture.
@brianteeman As far as I can see, these changes could also be done in 5.4-dev, as it not a new feature, only changing the CMS to not use deprecated code anymore. That's something we do already in 5.4. Or am I missing something? Unfortunately a rebase to 5.4-dev could be a bit messy right now until the next upmerge has been done. Maybe it would be easier to redo this and the 2 other PRs for 5.4-dev?