[#45790] - [6.0] mod_whosonline replace deprecated getUser
- Closed
- 31 Jul 2025
- Medium
- Build: 6.0-dev
- # 45790
- Diff
- brianteeman:whosonline
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This PR replaces the use of the deprecated getUser with getIdentity
Testing Instructions
Publish a whosonline module and check its behaviour before and after this pr - both as a guest and loged in user
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
No change
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
| Labels |
Added:
PR-6.0-dev
|
||
We might have to check the phpstan-baseline file if some entries (= errors to be ignored) can be removed. but maybe we should do that after this and similar PRs have been merged.
I have tested this item ✅ successfully on f2711c9
I have tested this successfully as well. Thanks @brianteeman.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45790.
I have tested this item ✅ successfully on f2711c9
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45790.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45790.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-07-31 09:41:20 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
RTC
|
||
We have the $app in this scope available so a Factory call is not needed. See #45792 (comment) for the bigger picture.
if this is correct I will work on similar deprecations