NPM Resource Changed PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
16 Jul 2025

Summary of Changes

The joomla alert used to display the information about the stats message uses a combination of a fake same page link and javascript to optionally disclose the information that is sent

This fake link is classed as an accessibility failure (and personally I see this as bad practice)

Broken same-page link. The link target does not match any element on the page.

We dont need to do it this way. If we use the details disclosure element we can make it work without the fake link and reduce the javascript needed.

In addition the default styling for the details element makes it visually much clearer that you can click to reveal than the existing underlined text

Testing Instructions

This pr includes js changes so you will need to test either with a prebuilt package or npm run build:js

Check that the information disclosure works in both the plugin and the dashboard message
Check that the two buttons still work

If you need to redisplay the message then you can set the plugin to "ask again" and in the database empty the contents of the params field for this plugin in the extensions table

Actual result BEFORE applying this Pull Request

Dashboard

image

Plugin

image

Expected result AFTER applying this Pull Request

Dashboard

image

Plugin

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 16 Jul 2025
avatar brianteeman brianteeman - change - 16 Jul 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jul 2025
Category JavaScript Repository NPM Change Front End Plugins
0642f67 16 Jul 2025 avatar brianteeman cs
avatar brianteeman brianteeman - change - 16 Jul 2025
Labels Added: NPM Resource Changed PR-5.4-dev
avatar hans2103 hans2103 - test_item - 16 Jul 2025 - Tested successfully
avatar hans2103
hans2103 - comment - 16 Jul 2025

I have tested this item ✅ successfully on f9b0aea

How I tested this

testing before the PR

apply PR as follows

visit Joomla Administrator and see a details/summary instead of broken same-page-link


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45736. Screenshot 2025-07-16 at 13 41 11 Screenshot 2025-07-16 at 13 41 26 Screenshot 2025-07-16 at 13 41 29
avatar richard67 richard67 - alter_testresult - 16 Jul 2025 - hans2103: Tested successfully
avatar richard67
richard67 - comment - 16 Jul 2025

I've restored @hans2103 's test result in the issue tracker because the commit which invalidated the test count was just code style.

avatar QuyTon QuyTon - test_item - 17 Jul 2025 - Tested successfully
avatar QuyTon
QuyTon - comment - 17 Jul 2025

I have tested this item ✅ successfully on 9cddb86


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45736.

avatar QuyTon QuyTon - change - 17 Jul 2025
Status Pending Ready to Commit
avatar QuyTon
QuyTon - comment - 17 Jul 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45736.

Add a Comment

Login with GitHub to post a comment