User tests: Successful: Unsuccessful:
The joomla alert used to display the information about the stats message uses a combination of a fake same page link and javascript to optionally disclose the information that is sent
This fake link is classed as an accessibility failure (and personally I see this as bad practice)
Broken same-page link. The link target does not match any element on the page.
We dont need to do it this way. If we use the details disclosure element we can make it work without the fake link and reduce the javascript needed.
In addition the default styling for the details element makes it visually much clearer that you can click to reveal than the existing underlined text
This pr includes js changes so you will need to test either with a prebuilt package or npm run build:js
Check that the information disclosure works in both the plugin and the dashboard message
Check that the two buttons still work
If you need to redisplay the message then you can set the plugin to "ask again" and in the database empty the contents of the params field for this plugin in the extensions table
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | JavaScript Repository NPM Change Front End Plugins |
Labels |
Added:
NPM Resource Changed
PR-5.4-dev
|
I have tested this item ✅ successfully on 9cddb86
Status | Pending | ⇒ | Ready to Commit |
RTC
I have tested this item ✅ successfully on f9b0aea
How I tested this
testing before the PR
apply PR as follows
visit Joomla Administrator and see a details/summary instead of broken same-page-link
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45736.