RTC Language Change PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
8 Jul 2025

This PR corrects the spelling of a language key

code review only

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 8 Jul 2025
avatar brianteeman brianteeman - change - 8 Jul 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Jul 2025
Category Administration Language & Strings Front End Plugins
avatar QuyTon QuyTon - test_item - 9 Jul 2025 - Tested successfully
avatar QuyTon
QuyTon - comment - 9 Jul 2025

I have tested this item ✅ successfully on 9f5e30d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45706.

avatar richard67
richard67 - comment - 9 Jul 2025

@brianteeman Do you know if it needs to deprecate the string, i.e. leave the one with the old key and add a deprecation comment?

avatar richard67
richard67 - comment - 9 Jul 2025

I think if we want to play safe we should deprecate the string with the old key for 7.0.

avatar brianteeman brianteeman - change - 10 Jul 2025
Labels Added: Language Change PR-5.4-dev
avatar exlemor exlemor - test_item - 11 Jul 2025 - Tested successfully
avatar exlemor
exlemor - comment - 11 Jul 2025

I have tested this item ✅ successfully on 7e0dacf

I have tested this successfully.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45706.

avatar chmst chmst - test_item - 11 Jul 2025 - Tested successfully
avatar chmst
chmst - comment - 11 Jul 2025

I have tested this item ✅ successfully on 7e0dacf

Code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45706.

avatar tecpromotion tecpromotion - change - 11 Jul 2025
Status Pending Ready to Commit
avatar tecpromotion
tecpromotion - comment - 11 Jul 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45706.

avatar muhme muhme - change - 12 Jul 2025
Labels Added: RTC
avatar muhme muhme - change - 12 Jul 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-07-12 07:39:43
Closed_By muhme
avatar muhme muhme - close - 12 Jul 2025
avatar muhme muhme - merge - 12 Jul 2025
avatar muhme
muhme - comment - 12 Jul 2025

Thank you @brianteeman. May I ask if you will create a subsequent 6.0 PR to delete the obsolete keys once this PR is upmerged? And thank you all commentators and testers.

Add a Comment

Login with GitHub to post a comment