Feeling Lucky
PR-5.4-dev
[#45673] - [5.4] Fix handling of responses from autoupdate server
- Fixed in Code Base
- 1 Jul 2025
- Medium
- Build: 5.4-dev
- # 45673
- Diff
- SniperSister:5.4-update-response-fix
User tests: Successful: Unsuccessful:
Summary of Changes
Don't blindly rely on the presence of specific response attributes by using the null coalescing operator.
Testing Instructions
Code Review.
Actual result BEFORE applying this Pull Request
PHP Warning: Undefined array key "status" in /tests/www/cmysql/administrator/components/com_joomlaupdate/src/Model/UpdateModel.php on line 618
Expected result AFTER applying this Pull Request
Fixed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate |
| Labels |
Added:
PR-5.4-dev
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-07-01 18:25:12 |
| Closed_By | ⇒ | muhme |
muhme
- comment
- 1 Jul 2025
Thanks @SniperSister for the immediate correction, thanks @Ruud68 for the valuable hint and thanks @richard67 for the code review.
@Ruud68 good catch, thx!