Language Change PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar RickR2H
RickR2H
1 Jul 2025

Pull Request for Issue # .

Summary of Changes

  • Added the option to define custom classes for the image class dropdown in the TinyMCE plugin configuration, while keeping the default classes.
  • When selecting "No Class Selected" in the image class dropdown, the class property is completely removed from the image.

image-class

Testing Instructions

  1. Build the CSS.
  2. Go to the TinyMCE plugin configuration.
  3. Scroll to the bottom of the page to the Image Classes List parameter.
  4. Click the green + symbol to add a custom class.
  5. Add a custom class with name: myclass and value: myclass.
  6. Go to an article and add an image.
  7. Select the image and click the image icon in the editor icon bar.
  8. Open the class dropdown and select the created class: myclass and click Save.
  9. Open the Source Code Editor in TinyMCE and check if the class is in the image tag.

    img-class-dropdown2
  10. Open the image dialog again and remove the class by clicking: No Class Selected.
  11. Check if the class property is removed from the image tag.

Actual result BEFORE applying this Pull Request

No classes can be added

Expected result AFTER applying this Pull Request

Classes can be added in the configuration and selected in the image class dropdown in TinyMCE

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar RickR2H RickR2H - open - 1 Jul 2025
avatar RickR2H RickR2H - change - 1 Jul 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Jul 2025
Category Administration Language & Strings Repository NPM Change Front End Plugins
avatar RickR2H
RickR2H - comment - 1 Jul 2025

@brianteeman Why a vote down?

avatar brianteeman
brianteeman - comment - 1 Jul 2025

it should be obvious that changing the markup is a b/c break

just because the cassiopeia template has

.float-none
 {
    float: none !important;
}

and that might be the same as not having any class does not mean that a site owner has not modified that class for their site

.float-none
 {
    float: none !important;
    border: 1px solid red;
}
avatar RickR2H RickR2H - change - 1 Jul 2025
Labels Added: Language Change NPM Resource Changed PR-5.4-dev
avatar joomla-cms-bot joomla-cms-bot - change - 1 Jul 2025
Category Administration Language & Strings Repository NPM Change Front End Plugins Administration Language & Strings Front End Plugins
avatar RickR2H RickR2H - change - 1 Jul 2025
The description was changed
avatar RickR2H RickR2H - edited - 1 Jul 2025
avatar RickR2H
RickR2H - comment - 1 Jul 2025

@brianteeman I get your point. I added back in the class and added an other option to remove the classes.

avatar richard67
richard67 - comment - 1 Jul 2025

If this is a new feature then it should go into 6.0-dev.

avatar RickR2H
RickR2H - comment - 1 Jul 2025

I guess it is a kind of a new feature... It is a way to configure the static classes in the image dropdown, which sould be possible right from the start IMHO. No problem to put this PR in the 6.0 branch though. Will check tomorrow.

avatar RickR2H RickR2H - close - 2 Jul 2025
avatar RickR2H
RickR2H - comment - 2 Jul 2025

Closed. Created a new PR: #45676

avatar RickR2H RickR2H - change - 2 Jul 2025
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2025-07-02 08:06:09
Closed_By RickR2H
Labels Removed: NPM Resource Changed
avatar ChristineWk
ChristineWk - comment - 2 Jul 2025

Hi Rick,
it's this one: #45676

Add a Comment

Login with GitHub to post a comment