[#45656] - [5.4] Fix registration error notification
- Fixed in Code Base
- 12 Jul 2025
- Medium
- Build: 5.4-dev
- # 45656
- Diff
- bembelimen:5.4/fix-registration-failures
User tests: Successful: Unsuccessful:
Summary of Changes
When a user registers on the frontend there are several validations before it's saved. After saving several emails are sent by the system. Now if the email sending fails for some reason the user is redirected back to the registration form and an error message is shown, although the user is registered. That means, if the user tries it again, it gets the message, that the username/email is already used. This makes not really sense, especially the user can't do anything with the error messages. So this PR does not redirect the user back to the registration form after the user is created. It also removed the "admin error messages" which should still be logged but not shown to the end user.
Testing Instructions
- Apply patch
- Disable the email function in the configuration (Send Emails)
- Register a new user
Actual result BEFORE applying this Pull Request
User is redirected back to form and get some errors which are not helpful:
Expected result AFTER applying this Pull Request
Registration was successful but warning shown:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_users |
| Labels |
Added:
PR-5.4-dev
|
||
I understand the reasons behind this PR (its the same problem as #29169) but the messages are still wrong. They still indicate that an email has been sent when it hasnt. So now the user will still search for an email and when its not been received will try again
Hi @brianteeman ,
thanks for the feedback. I'm not sure how to fix that, as it's hard to tell, if an email was sent or if something else failed. I hoped the message on top made it clear, what went wrong. Probably we could add something like: "They will get in touch with you."
I have tested this item ✅ successfully on cee8dc6
Tested clean J5.3.2 installation and this 5.4+PR update. All is ok.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45656.
I have tested this item ✅ successfully on cee8dc6
I have tested this successfully. Never encountered this situation but nice that it is getting updated :) Thanks Benjamin.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45656.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45656.
| Labels |
Added:
RTC
|
||
My results from the last test before merging:
- Before PR, I was not able to reproduce the shown error message 'Could not instantiate mail function.'
- I am getting 'The mail function has been disabled by an administrator.' if
Send Mailis disabled. - Or 'SMTP Error: Could not connect to SMTP host. Failed to connect to server' if
smtphostis changed to non-existing hostname
- I am getting 'The mail function has been disabled by an administrator.' if
- After applying the PR with disabled
Send Mail- ✅ Error message 'An error was encountered while sending the registration email. A message has been sent to the administrator of this site.' is shown.
- ✅ The user is no longer redirected to the registration form, instead to
component/users/registration?layout=complete
As @brianteeman already stated:
They still indicate that an email has been sent when it hasnt.
- As email is disabled there is no email sent to the administrator.
- As the user has to verify the email address via a link sent by email, they are still unable to login as the account is not activated: 'Login denied! Your account has either been blocked or you have not activated it yet.'
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-07-12 05:51:42 |
| Closed_By | ⇒ | muhme |
Thank you @bembelimen and all contributers, commentators and testers.
I understand the reasons behind this PR (its the same problem as #29169) but the messages are still wrong. They still indicate that an email has been sent when it hasnt. So now the user will still search for an email and when its not been received will try again