Feeling Lucky
Unit/System Tests
PR-6.0-dev
[#45655] - [6.0] Phpstan baseline
- Pending
- Medium
- Build: 5.3-dev
- # 45655
- Diff
- rdeutz:phpstan-baseline
User tests: Successful: Unsuccessful:
Summary of Changes
This PR changes the behaviour of the CI System. We use PHPStan but ignore the failue of it. This is not the best option for further development. PHPStan has a baseline option and with this file it allows to ignore current failures. But it will still fail when new failures are added to the system. This doesn't make the current code better but makes sure it doesn't get wrose.
Testing Instructions
After this change the build should be green even the phpstan step.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests Repository Administration com_admin SQL |
| Labels |
Added:
Unit/System Tests
PR-6.0-dev
|
||
| Category | Unit Tests Repository Administration com_admin SQL | ⇒ | Unit Tests |
rdeutz
- comment
- 25 Jun 2025
I don't think it will fail when you fix things. But the amount of messages makes it close to impossible to find a new thing.
The thing is that it also fails the whole PR when issues are fixed and are not part of the baseline anymore. Since we plan to fix lots of issues in 6.0 in regards to errors and JFactory in the near future, I'm hesitant to add this now.