[#45627] - [6.0] Remove call to 'toPunycode' which throws error for files with '_'
- Ready to Commit
- Medium
- Build: 6.0-dev
- # 45627
- Diff
- MacJoom:fix_4584_Localadapter_remove_toPunycode
User tests: Successful: Unsuccessful:
Pull Request for Issue #45484.
Summary of Changes
Remove call to 'toPunycode' in getSafeName which throws error for files with underscores
Testing Instructions
- Upload files with underscores in the name
- Upload all kind of files with weird filenames
File should upload. Special chars should be changed in the uploaded filename
Actual result BEFORE applying this Pull Request
Nothing happens - see Issue
Expected result AFTER applying this Pull Request
File is uploaded
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Labels |
Added:
PR-6.0-dev
|
||
I have tested this item 🔴 unsuccessfully on 48f40f8
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45627.
I have tested this item ✅ successfully on 48f40f8
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45627.
| Title |
|
||||||
I have tested this item ✅ successfully on 48f40f8
I have test this successfully with: imageäöütest.jpg, acs-delivering_package2_copy.jpg and imageäöütest_pack_test.jpg all were uploaded with appropriate substitution.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45627.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45627.
| Labels |
Added:
RTC
Release Blocker
bug
|
||
this PR is not correct. Before this PR if you have a filename using ut8 characters it will be uploaded and cleanedwith this PR the file is simply not uploaded
Test by creating an image with the filename imageäöütest.jpgBefore this pr it will be saved as imageaoutest.jpgWith this pr nothing happens to the imageunrelated bug