RTC Unit/System Tests Language Change UI/UX PR-6.0-dev Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
9 Jun 2025

Pull Request for Issue # .

Summary of Changes

Editing the access level is split in two tabs: One tab for the name, another for the groups having access.
This means - when you are on the groups tab, you cannot be sure if you are editing the right access level.

This PR integrates access level name and groups with access in one area.

Testing Instructions

Edit access levels before and after patch. The result of editing must be the same

Actual result BEFORE applying this Pull Request

grafik

Expected result AFTER applying this Pull Request

grafik

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar chmst chmst - open - 9 Jun 2025
avatar chmst chmst - change - 9 Jun 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Jun 2025
Category Administration com_users
avatar chmst chmst - change - 9 Jun 2025
The description was changed
avatar chmst chmst - edited - 9 Jun 2025
avatar chmst chmst - change - 9 Jun 2025
Labels Added: UI/UX PR-6.0-dev
avatar joomla-cms-bot joomla-cms-bot - change - 9 Jun 2025
Category Administration com_users Administration com_users Language & Strings
avatar brianteeman
brianteeman - comment - 9 Jun 2025

Wow - I never spotted this before. Definitely an improvement

avatar richard67
richard67 - comment - 10 Jun 2025

The system tests are failing at the "1) can open the access level form" step, so they need to be adjusted to the changes in this PR.

avatar brianteeman
brianteeman - comment - 10 Jun 2025

There are two failing tests.

They are failing because it is looking for

image

Maybe change Level Details to User Groups With Viewing Access

avatar chmst chmst - change - 10 Jun 2025
Labels Added: Language Change
avatar joomla-cms-bot joomla-cms-bot - change - 10 Jun 2025
Category Administration com_users Language & Strings Administration com_users Language & Strings JavaScript Unit Tests
avatar chmst
chmst - comment - 10 Jun 2025

Hope this helps. Thank you @brianteeman and @richard67

avatar brianteeman brianteeman - test_item - 10 Jun 2025 - Tested successfully
avatar brianteeman
brianteeman - comment - 10 Jun 2025

I have tested this item ✅ successfully on fe6100d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45588.

avatar brianteeman
brianteeman - comment - 10 Jun 2025

I wonder if perhaps the UI would be more consistent if it was like this

image

avatar chmst
chmst - comment - 10 Jun 2025

@brianteeman looks good - will change it.

avatar ceford ceford - test_item - 10 Jun 2025 - Tested successfully
avatar ceford
ceford - comment - 10 Jun 2025

I have tested this item ✅ successfully on fe6100d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45588.

avatar richard67
richard67 - comment - 10 Jun 2025

As far as I understood there will be made some change to this PR to implement @brianteeman 's suggestion, so I'm waiting with RTC.

avatar chmst chmst - change - 10 Jun 2025
Labels Added: Unit/System Tests
avatar chmst
chmst - comment - 10 Jun 2025

Following @brianteeman 's suggetion, the tab around the content is restored.
Could you re-test?

New appearance:

grafik

24fac7a 10 Jun 2025 avatar chmst cs
avatar brianteeman brianteeman - test_item - 10 Jun 2025 - Tested successfully
avatar brianteeman
brianteeman - comment - 10 Jun 2025

I have tested this item ✅ successfully on 24fac7a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45588.

avatar ceford ceford - test_item - 10 Jun 2025 - Tested successfully
avatar ceford
ceford - comment - 10 Jun 2025

I have tested this item ✅ successfully on 24fac7a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45588.

avatar richard67 richard67 - change - 10 Jun 2025
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 10 Jun 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45588.

avatar Bodge-IT Bodge-IT - change - 11 Jun 2025
Labels Added: RTC
avatar Bodge-IT Bodge-IT - close - 11 Jun 2025
avatar Bodge-IT Bodge-IT - merge - 11 Jun 2025
avatar Bodge-IT Bodge-IT - change - 11 Jun 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-06-11 18:48:32
Closed_By Bodge-IT
avatar Bodge-IT
Bodge-IT - comment - 11 Jun 2025

Thanks @chmst, good catch and thanks to @ceford and @brianteeman for testing

Add a Comment

Login with GitHub to post a comment