RTC Language Change NPM Resource Changed PR-6.0-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
21 May 2025

This PR removes the language files AND images for the j5 whats new guided tours from NEW installs of j6 as these guided tours are not available on a clean install of j6

They are still available on a site that has been updated from j5 unless we remove the tours completely in an sql update (which I can do as well if maintainers decide thats the way to go)

@richard67 you might need to create an exception for these files in your deleted files script as they should be available on sites updated to j6 (unless we remove the tours completely in an sql update)

avatar brianteeman brianteeman - open - 21 May 2025
avatar brianteeman brianteeman - change - 21 May 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 May 2025
Category Administration Language & Strings
avatar brianteeman brianteeman - change - 21 May 2025
Labels Added: Language Change PR-6.0-dev
avatar joomla-cms-bot joomla-cms-bot - change - 21 May 2025
Category Administration Language & Strings Administration Language & Strings Repository NPM Change
avatar brianteeman brianteeman - change - 21 May 2025
The description was changed
avatar brianteeman brianteeman - edited - 21 May 2025
avatar brianteeman brianteeman - change - 21 May 2025
The description was changed
avatar brianteeman brianteeman - edited - 21 May 2025
avatar brianteeman brianteeman - change - 21 May 2025
Labels Added: NPM Resource Changed
avatar exlemor
exlemor - comment - 1 Jun 2025

Hello @brianteeman, could I/we have some Testing Instructions, please? (thank you so much, just want to make sure I am doing the right process and getting the right results)

avatar brianteeman
brianteeman - comment - 5 Jun 2025

This PR removes the language files AND images for the j5 whats new guided tours from NEW installs of j6 as these guided tours are not available on a clean install of j6

Check that a pre-built installation package does not contain the files removed by this pr

avatar exlemor exlemor - test_item - 6 Jun 2025 - Tested successfully
avatar exlemor
exlemor - comment - 6 Jun 2025

I have tested this item ✅ successfully on 8dbdaec

I have tested this successfully and as discussed with Gary, he will also do a code review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45512.

avatar QuyTon QuyTon - test_item - 6 Jun 2025 - Tested successfully
avatar QuyTon
QuyTon - comment - 6 Jun 2025

I have tested this item ✅ successfully on 8dbdaec


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45512.

avatar QuyTon QuyTon - change - 6 Jun 2025
Status Pending Ready to Commit
avatar QuyTon
QuyTon - comment - 6 Jun 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45512.

avatar Bodge-IT Bodge-IT - change - 11 Jun 2025
Labels Added: RTC
avatar Bodge-IT
Bodge-IT - comment - 12 Jun 2025

Thank you @brianteeman for catching this and @QuyTon & @exlemor for testing

avatar Bodge-IT Bodge-IT - change - 12 Jun 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-06-12 05:49:11
Closed_By Bodge-IT
avatar Bodge-IT Bodge-IT - close - 12 Jun 2025
avatar Bodge-IT Bodge-IT - merge - 12 Jun 2025

Add a Comment

Login with GitHub to post a comment