Test instructions missing NPM Resource Changed PR-6.0-dev Pending

User tests: Successful: Unsuccessful:

avatar Bodge-IT
Bodge-IT
21 May 2025

Conflicting code from 44090 & 45242 now uses latest getDatabase() method (NewsfeedTable.php line 180).

avatar Bodge-IT Bodge-IT - open - 21 May 2025
avatar Bodge-IT Bodge-IT - change - 21 May 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 May 2025
Category Administration com_banners com_categories com_contact com_fields com_finder com_joomlaupdate com_media NPM Change com_menus com_newsfeeds com_redirect com_tags com_templates com_users
avatar joomla-cms-bot
joomla-cms-bot - comment - 21 May 2025

Please add more information to your issue. Without test instructions and/or any description we will close this issue within 4 weeks. Thanks.
This is an automated message from the J!Tracker Application.

avatar Bodge-IT Bodge-IT - change - 21 May 2025
Labels Added: Test instructions missing NPM Resource Changed PR-6.0-dev
avatar Bodge-IT Bodge-IT - change - 21 May 2025
The description was changed
avatar Bodge-IT Bodge-IT - edited - 21 May 2025
avatar brianteeman
brianteeman - comment - 21 May 2025

the language files for the 5.4 guided tours should not be included as this tour is not available in a clean j6 (same for the other whats new tour language files already upmerged in to j6)

see #45512

avatar Bodge-IT
Bodge-IT - comment - 21 May 2025

the language files for the 5.4 guided tours should not be included as this tour is not available in a clean j6 (same for the other whats new tour language files already upmerged in to j6)

see #45512

Thanks for the catch @brianteeman, I've modified this PR and will add the language files on your PR to our list of exclusions.

avatar richard67
richard67 - comment - 21 May 2025

Shouldn't file build/media_source/com_guidedtours/images/5_4/automated-updates.jpg also be removed if the ini files for the "What's new in 5.4" guided tour are removed?

avatar Bodge-IT
Bodge-IT - comment - 21 May 2025

There's nothing uniquely 5.4 about that image though? There are also images for 5.2 and 5.3, also generic. Should these also be removed?

avatar richard67
richard67 - comment - 21 May 2025

There's nothing uniquely 5.4 about that image though? There are also images for 5.2 and 5.3, also generic. Should these also be removed?

@Bodge-IT Sure it's uniquely for 5.4, or why do you think it's in a folder 5.4 and shows autoupdate stuff?

Anyway, you can leave it to PR #45512 to remove it.

avatar Bodge-IT Bodge-IT - change - 21 May 2025
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-05-21 15:50:41
Closed_By Bodge-IT
avatar Bodge-IT Bodge-IT - close - 21 May 2025
avatar Bodge-IT Bodge-IT - merge - 21 May 2025
avatar Bodge-IT
Bodge-IT - comment - 21 May 2025

Tried to remove the .54 image but Github wouldn't allow.

avatar brianteeman
brianteeman - comment - 21 May 2025

Tried to remove the .54 image but Github wouldn't allow.

i have added that image to #45512

Add a Comment

Login with GitHub to post a comment