RMDQ PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar pe7er
pe7er
20 May 2025

Same issue as #45501 with some more components: When you save a task with spaces, before or after the title, the spaces are saved in the database.

Summary of Changes

This PR trims (removes spaces before and after) the title for:

  • com_finder: Filters
  • com_guidedtours: Tour
  • com_guidedtours: Tour > Step
  • com_mails: Mail Templates

Testing Instructions

In backend go to the components, edit title, add a lot of spaces in front of the title, and save.

Actual result BEFORE applying this Pull Request

Components > Smart Search > Filters
smart-search-filter-before

System > Guided Tours > edit Title
guided-tours-before

System > Guided Tours > edit Steps (click on the Steps number and open + edit a Step)
guided-tours-step-before

System > Mail Templates
mail-template-before

Expected result AFTER applying this Pull Request

Components > Smart Search > Filters
smart-search-filter-after

System > Guided Tours > edit Title
guided-tour-after

System > Guided Tours > edit Steps (click on the Steps number and open + edit a Step)
guided-tours-step-after

System > Mail Templates
mail-template-after

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar pe7er pe7er - open - 20 May 2025
avatar pe7er pe7er - change - 20 May 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 May 2025
Category Administration com_finder
avatar exlemor exlemor - test_item - 21 May 2025 - Tested successfully
avatar exlemor
exlemor - comment - 21 May 2025

I have tested this item ✅ successfully on 55177e9

I have tested this successfully as well ! :)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45509.

avatar krishnaGandhi11 krishnaGandhi11 - test_item - 23 May 2025 - Tested successfully
avatar krishnaGandhi11
krishnaGandhi11 - comment - 23 May 2025

I have tested this item ✅ successfully on 55177e9

Tested successfully, works as expected!


Thanks again for test-instructions(super helpful as it covers all the checks for PRs),
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45509.

avatar QuyTon QuyTon - change - 23 May 2025
Status Pending Ready to Commit
Labels Added: PR-5.3-dev
avatar QuyTon
QuyTon - comment - 23 May 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45509.

avatar Fedik Fedik - change - 25 May 2025
Status Ready to Commit Pending
avatar Fedik
Fedik - comment - 25 May 2025
avatar webmasterab webmasterab - test_item - 25 May 2025 - Tested successfully
avatar webmasterab
webmasterab - comment - 25 May 2025

I have tested this item ✅ successfully on 55177e9

Tested successfully, works as expected!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45509.

avatar HLeithner HLeithner - close - 4 Jun 2025
avatar HLeithner
HLeithner - comment - 4 Jun 2025

Hi @pe7er

thanks for the PR but we discussed this now several times in maintainers channel and come to the following conclusion:

  1. Fedir mentioned in comment that this would prevent our default filter
  2. We shouldn't touch user input if not really needed.

So I'm closing this PR.

avatar HLeithner HLeithner - change - 4 Jun 2025
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2025-06-04 18:21:02
Closed_By HLeithner
Labels Added: RMDQ

Add a Comment

Login with GitHub to post a comment