RMDQ PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar pe7er
pe7er
20 May 2025

Same issue as #45501 with multiple components: When you save a task with spaces, before or after the title, the spaces are saved in the database.

Summary of Changes

This PR trims (removes spaces before and after) the title for:

  • com_banners: banners
  • com_banners: banner clients
  • com_contacts: contacts
  • com_languages: content languages
  • com_newsfeeds: Newsfeeds
  • com_templates: Template Style

Testing Instructions

In backend go to the components, edit title, add a lot of spaces in front of the title, and save.

Actual result BEFORE applying this Pull Request

Components > Banners > Banners
banner-before

Components > Banners > Clients
banner-client-before

Components > Contacts > Contacts
contact-before

System > Content Languages
language-content-before

Components > Newsfeeds > Feeds
newsfeed-before

System > Site Template Styles or Admin Templates
template-style-before

Expected result AFTER applying this Pull Request

Components > Banners > Banners
banner-after

Components > Banners > Clients
banner-client-after

Components > Contacts > Contacts
contact-after

System > Content Languages
language-content-after

Components > Newsfeeds > Feeds
newsfeed-after

System > Site Template Styles or Admin Templates
template-style-after

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar pe7er pe7er - open - 20 May 2025
avatar pe7er pe7er - change - 20 May 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 May 2025
Category Administration com_banners com_contact com_languages com_newsfeeds com_templates
avatar exlemor exlemor - test_item - 20 May 2025 - Tested successfully
avatar exlemor
exlemor - comment - 20 May 2025

I have tested this item ✅ successfully on 8b4b4dc

I have tested com_banners: banners, com_banners: banner clients, com_contacts: contacts, com_languages: content languages, com_newsfeeds: Newsfeeds, com_templates: Template Style successfully! thank pe7er!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45508.

avatar krishnaGandhi11 krishnaGandhi11 - test_item - 23 May 2025 - Tested successfully
avatar krishnaGandhi11
krishnaGandhi11 - comment - 23 May 2025

I have tested this item ✅ successfully on 8b4b4dc

Tested successfully, works as expected!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45508.

avatar QuyTon QuyTon - change - 23 May 2025
Status Pending Ready to Commit
Labels Added: PR-5.3-dev
avatar QuyTon
QuyTon - comment - 23 May 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45508.

avatar Fedik Fedik - change - 25 May 2025
Status Ready to Commit Pending
avatar Fedik
Fedik - comment - 25 May 2025
avatar webmasterab webmasterab - test_item - 25 May 2025 - Tested successfully
avatar webmasterab
webmasterab - comment - 25 May 2025

I have tested this item ✅ successfully on 8b4b4dc

Tested


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45508.

avatar HLeithner HLeithner - close - 4 Jun 2025
avatar HLeithner
HLeithner - comment - 4 Jun 2025

Hi @pe7er

thanks for the PR but we discussed this now several times in maintainers channel and come to the following conclusion:

  1. Fedir mentioned in comment that this would prevent our default filter
  2. We shouldn't touch user input if not really needed.

So I'm closing this PR.

avatar HLeithner HLeithner - change - 4 Jun 2025
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2025-06-04 18:21:05
Closed_By HLeithner
Labels Added: RMDQ

Add a Comment

Login with GitHub to post a comment