[#45497] - [5.4] fix task notification for updated Joomla versions (prior 5.3)
- Pending
- Medium
- Build: 5.3-dev
- # 45497
- Diff
- heelc29:5.3/issue-45488
User tests: Successful: Unsuccessful:
Pull Request for Issue #45488 caused due #44604.
Summary of Changes
add default value for params.notifications.notification_XXX_groups to match default xml value
UPDATE: #45497 (comment)
The hard coded default user group number 8 works only on sites where the user groups have not been modified.
So if no user groups configured, fallback to Super Users user group is used. Can be alternative changed to send no email.
Testing Instructions
- Install a Joomla-Version lower 5.3.0 (eg. 5.2.6)
- Create Task with (success) notification (and check if it works)
- Update to Joomla 5.3.0
- Check if notification still works
Actual result BEFORE applying this Pull Request
No email is send
Expected result AFTER applying this Pull Request
Email is send (again)
Link to documentations
Please select:
- No documentation changes for docs.joomla.org needed
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins JavaScript Unit Tests |
| Title |
|
||||||
| Labels |
Added:
Unit/System Tests
PR-5.3-dev
|
||
@Eric69-dev - unsure how you were able to test this successfully - I just tried and was unsuccessful but I prefer others test it to validate my findings.
| Labels |
Added:
PBF
|
||
This pull request has been automatically rebased to 5.4-dev.
| Labels |
Added:
bug
|
||
| Title |
|
||||||
| Labels |
Added:
PR-5.4-dev
Removed: PBF PR-5.3-dev |
||
@heelc29 The hard coded default user group number 8 works only on sites where the user groups have not been modified. But we cannot rely on it on updated sites. We had a similar discussion for the automated updates notifications, see PR #45721 how that was solved at the end.
Ok. That means also to remove the default value from the xml file?
Ok. That means also to remove the default value from the xml file?
@heelc29 I think yes, on the long run. I know, it's a rabbit hole.
Unfortunately we do not have a list of core groups which we do not allow to modify, so people dan do anything with these groups. They can create a new superuser group with a completely different name, and even remove privileges from the default superuser group, or even delete that group.
So all use of any hard coded group number is an old design flaw.
PR updated
I have tested this item ✅ successfully on 0b4963c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45497.
Hello,
This PR has been in progress for several months. However, I use the fix successfully on my instances.
This prevents Joomla from updating until the PR is included in a release. Is there any chance this will happen soon?
Thank you in advance.
Regards,
Eric