RTC Unit/System Tests bug PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
19 May 2025

Pull Request for Issue #45488 caused due #44604.

Summary of Changes

add default value for params.notifications.notification_XXX_groups to match default xml value

<field
name="notification_success_groups"
type="usergrouplist"
label="PLG_SYSTEM_TASK_NOTIFICATION_SUCCESS_USERGROUP_LABEL"
multiple="true"
layout="joomla.form.field.list-fancy-select"
checksuperusergroup="0"
default="8"
showon="success_mail:1"
>

UPDATE: #45497 (comment)

The hard coded default user group number 8 works only on sites where the user groups have not been modified.

So if no user groups configured, fallback to Super Users user group is used. Can be alternative changed to send no email.

Testing Instructions

  • Install a Joomla-Version lower 5.3.0 (eg. 5.2.6)
  • Create Task with (success) notification (and check if it works)
  • Update to Joomla 5.3.0
  • Check if notification still works

Actual result BEFORE applying this Pull Request

No email is send

Expected result AFTER applying this Pull Request

Email is send (again)

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar heelc29 heelc29 - open - 19 May 2025
avatar heelc29 heelc29 - change - 19 May 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 May 2025
Category Front End Plugins JavaScript Unit Tests
avatar heelc29 heelc29 - change - 19 May 2025
Title
5.3/issue 45488
[5.3] fix task notification for updated Joomla versions (prior 5.3)
avatar heelc29 heelc29 - edited - 19 May 2025
avatar heelc29 heelc29 - change - 20 May 2025
Labels Added: Unit/System Tests PR-5.3-dev
avatar Eric69-dev
Eric69-dev - comment - 20 Aug 2025

Hello,

This PR has been in progress for several months. However, I use the fix successfully on my instances.

This prevents Joomla from updating until the PR is included in a release. Is there any chance this will happen soon?

Thank you in advance.

Regards,
Eric

avatar exlemor
exlemor - comment - 23 Aug 2025

@Eric69-dev - unsure how you were able to test this successfully - I just tried and was unsuccessful but I prefer others test it to validate my findings.

avatar heelc29 heelc29 - change - 23 Aug 2025
Labels Added: PBF
avatar HLeithner
HLeithner - comment - 15 Oct 2025

This pull request has been automatically rebased to 5.4-dev.

avatar heelc29 heelc29 - change - 15 Oct 2025
Labels Added: bug
avatar richard67 richard67 - change - 20 Oct 2025
Title
[5.3] fix task notification for updated Joomla versions (prior 5.3)
[5.4] fix task notification for updated Joomla versions (prior 5.3)
avatar richard67 richard67 - edited - 20 Oct 2025
avatar heelc29 heelc29 - change - 1 Nov 2025
Labels Added: PR-5.4-dev
Removed: PBF PR-5.3-dev
avatar richard67
richard67 - comment - 1 Nov 2025

@heelc29 The hard coded default user group number 8 works only on sites where the user groups have not been modified. But we cannot rely on it on updated sites. We had a similar discussion for the automated updates notifications, see PR #45721 how that was solved at the end.

avatar heelc29
heelc29 - comment - 1 Nov 2025

@heelc29 The hard coded default user group number 8 works only on sites where the user groups have not been modified. But we cannot rely on it on updated sites. We had a similar discussion for the automated updates notifications, see PR #45721 how that was solved at the end.

Ok. That means also to remove the default value from the xml file?




avatar richard67
richard67 - comment - 1 Nov 2025

Ok. That means also to remove the default value from the xml file?

@heelc29 I think yes, on the long run. I know, it's a rabbit hole.

Unfortunately we do not have a list of core groups which we do not allow to modify, so people dan do anything with these groups. They can create a new superuser group with a completely different name, and even remove privileges from the default superuser group, or even delete that group.

So all use of any hard coded group number is an old design flaw.

avatar heelc29 heelc29 - change - 5 Nov 2025
The description was changed
avatar heelc29 heelc29 - edited - 5 Nov 2025
avatar heelc29
heelc29 - comment - 5 Nov 2025

PR updated

avatar alikon alikon - test_item - 30 Nov 2025 - Tested successfully
avatar alikon
alikon - comment - 30 Nov 2025

I have tested this item ✅ successfully on 0b4963c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45497.

avatar exlemor
exlemor - comment - 5 Dec 2025

Hi @heelc29, I must be doing something wrong as I am not getting an email after having installed the Download package (started from a Joomla! 5.2.6 fresh environment with Blog Sample Data and Multilingual Sample Data (+French language)... ;(

avatar muhme muhme - test_item - 16 Dec 2025 - Tested successfully
avatar muhme
muhme - comment - 16 Dec 2025

I have tested this item ✅ successfully on 0b4963c

Tested with JBT

  • Installed 5.2.6, modified 'Session GC' task to run every minute and send Task success notifications
    • Seen every minute an email with Task Successful
  • Updated by file upload Joomla_5.3.4-Stable-Update_Package.zip
    • Seen every minute the 'Last Run Date' is updated, but no email sent
  • Updated by file upload with nighlty Joomla_5.4.2-dev-Development-Update_Package.zip
    • Seen problem is still present, every minute the 'Last Run Date' is updated, but no email sent
  • Applied PR by updating with PR update package
    • ✅ Emails are sent every minute and also for manual 'Run Test'
    • ✅ No Joomla or PHP noticeable log messages

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45497.
avatar richard67 richard67 - change - 16 Dec 2025
Status Pending Ready to Commit
Build 5.3-dev 5.4-dev
avatar richard67
richard67 - comment - 16 Dec 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45497.

avatar muhme
muhme - comment - 16 Dec 2025

@heelc29 we don't have the right to update, could you please merge the branch into this PR, if we see everything is green, we will merge, thx

avatar heelc29 heelc29 - change - 16 Dec 2025
Labels Added: RTC
avatar muhme muhme - change - 17 Dec 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-12-17 05:48:49
Closed_By muhme
avatar muhme muhme - close - 17 Dec 2025
avatar muhme muhme - merge - 17 Dec 2025
avatar muhme
muhme - comment - 17 Dec 2025

Thank you @heelc29 for your contribution. Thank you @brianteeman and @richard67 for your support. Thank you @alikon and @exlemor for testing.

avatar muhme
muhme - comment - 17 Dec 2025

@Eric69-dev the fix is now included in version 5.4.2 and will be up-merged into 6.0.2, both of which are scheduled for release on 6 January.

avatar Eric69-dev
Eric69-dev - comment - 7 Jan 2026

@Eric69-dev the fix is now included in version 5.4.2 and will be up-merged into 6.0.2, both of which are scheduled for release on 6 January.

Thank you very much !

Add a Comment

Login with GitHub to post a comment