Pull Request for Issue # .

Summary of Changes

This pull request (PR) adds 2 new checks to the "Required Settings" checks of the pre-update checker which are shown when an update to the next major version (here 6) is found:

1. Check if the backward compatibility plugin of the current major version (here 5) is disabled.
2. Check if the backward compatibility plugin of the next major version (here 6) is enabled.

If one of these checks fails, you cannot update to the next major version with Live Update.

You can bypass these tests by using the "Upload & Update" button, but that's already the case with other required settings checks and should be fixed with another PR, if ever.

In addition, this PR adds the same checks to the CLI's core::update command.

The first check has been agreed by the CMS Maintenance Team.

The plugin has to be disabled before the update so the user can see if the site crashes due to a 3rd party extension like e.g. a system plugin which requires the plugin so it very likely will not work anymore on Joomla 6.

If that happens, the user can enable it again in the database and the site is operable again, e.g. fopr updating or uninstalling that extension.

If we would not do that, the site would break during the update when files are already unpacked but the database has not been updated yet, and that would be fixed not that easy.

The second check is for the case that the admin has disabled the J6 b/c plugin, what one should not do, but we can't really prevent it.

Testing Instructions

Test 1: Update to 6.0 nightly build

1. On a current 5.4-dev branch or latest 5.4 nightly build without the changed from this PR applied, make sure that automated updates are switched off and the "Behaviour - Backward Compatibility" plugin is enabled.

2. In the options of the Joomla Update Component, set the update channel to "Custom URL" and enter the custom update URL of the 6.0 nightly builds: https://update.joomla.org/core/nightlies/next_major_list.xml

3. Check for updates.
   Result: See section "Actual result BEFORE applying this Pull Request" below.

4. In a command line in your Joomla root folder, run php ./cli/joomla.php core:update.
   Result: See section "Actual result BEFORE applying this Pull Request" below.

5. Restore the starting conditions described in steps 1 and 2.

6. Apply the changes from this PR.

7. Check again for updates.
   Result: There are 2 new checks in the "Required Settings" section of the pre-update check.
   The first check for the J5 plugin has failed, and a notice is shown with a link to the plugin manager, telling to disable the plugin, and you can not update to Joomla 6 with Live Update.
   See first image "1. Both plugins enabled" in section "Expected result AFTER applying this Pull Request" below.

8. In a command line in your Joomla root folder, run php ./cli/joomla.php core:update.
   Result: There is a new step for checking the pre-conditions for a major update after the dcheck of the database table structure.
   It shows an error message telling that the 'Behavior - Backward Compatibility' plugin is enabled and a message that the pre-conditions for a major upgrade are not fulfilled.
   See second image "1. Both plugins enabled" in section "Expected result AFTER applying this Pull Request" below.

9. Disable the "Behaviour - Backward Compatibility 6" plugin.

10. Check again for updates.
    Result: Both checks have failed, and for each of the 2 plugins a notice is shown with a link to the plugin manager, telling what to do with the particular plugin, and you can not update to Joomla 6 with Live Update.
    See first image "2. Joomla 5 plugin enabled and Joomla 6 plugin disabled" in section "Expected result AFTER applying this Pull Request" below.

11. In a command line in your Joomla root folder, run php ./cli/joomla.php core:update.
    Result: The new check shows for each of the 2 plugins an error message with the plugin's translated name and its actual status, and finally a message that the pre-conditions for a major upgrade are not fulfilled.
    See second image "2. Joomla 5 plugin enabled and Joomla 6 plugin disabled" in section "Expected result AFTER applying this Pull Request" below.

12. Disable the "Behaviour - Backward Compatibility" plugin.

13. Check again for updates.
    Result: The second check for the J6 plugin has failed, and a notice is shown with a link to the plugin manager, telling to enable the plugin, and you can not update to Joomla 6 with Live Update.
    See first image "3. Both plugins disabled" in section "Expected result AFTER applying this Pull Request" below.

14. In a command line in your Joomla root folder, run php ./cli/joomla.php core:update.
    Result: The new check shows an error message telling that the 'Behavior - Backward Compatibility 6' plugin is disabled and a message that the pre-conditions for a major upgrade are not fulfilled.
    See second image "3. Both plugins disabled" in section "Expected result AFTER applying this Pull Request" below.

15. Enable the "Behaviour - Backward Compatibility 6" plugin.

16. Check again for updates.
    Result: Both new checks have succeeded, and you could update to Joomla 6.
    See first image "4. Joomla 5 plugin disabled and Joomla 6 plugin enabled" in section "Expected result AFTER applying this Pull Request" below.

17. In a command line in your Joomla root folder, run php ./cli/joomla.php core:update.
    Result: The update is executed.
    See second image "4. Joomla 5 plugin disabled and Joomla 6 plugin enabled" in section "Expected result AFTER applying this Pull Request" below.

Test 2: Update to 5.4 nightly build

1. On a current 5.4-dev branch or latest 5.4 nightly build, make sure that automated updates are switched off.

2. Apply the changes from this PR.

3. Edit file libraries/src/Version.php and change line 50 from public const MINOR_VERSION = 4; to public const MINOR_VERSION = 3;.
   This will fake the current version to be 5.3 so that an update to a 5.4 nightly can be found.

4. Go to "Extensions - Manage - Database", select the CMS record and use the "Update Structure" button.
   This will apply the faked version from step 3 in the database.

5. In the options of the Joomla Update Component, set the update channel to "Custom URL" and enter the custom update URL of the 5.4 nightly builds: https://update.joomla.org/core/nightlies/next_minor_list.xml

6. Check for updates.
   Result: The new checks are not shown in the pre-update check as it is not a major upgrade.
   See Test 2 in section "Expected result AFTER applying this Pull Request" below.

7. In a command line in your Joomla root folder, run php ./cli/joomla.php core:update.
   Result: There is no check of the pre-conditions for a major upgrade performed. The update is executed.
   See Test 2 in section "Expected result AFTER applying this Pull Request" below.

Actual result BEFORE applying this Pull Request

There is no check about backward compatibility plugins in the "Required Settings" checks of the pre-update checker, and you could update to J6.

When running the CLI core update command, the update is executed.

There is not check for the prerequisites to upgrade to a new major version.

Expected result AFTER applying this Pull Request

Test 1: Update to 6.0 nightly build

When an update to a new major version has been found, there are 2 new checks shown in the "Required Settings" section of the pre-update check:

• The Joomla 5 Backward Compatibility plugin is disabled
• The Joomla 6 Backward Compatibility plugin is enabled

When one of these checks of both have failed, you can't update with Live Update.

If both checks succeed, the button to perform the update is shown, so you could perform the update.

In the core:update command of the CLI there is a new step for checking the pre-conditions of a major upgrade when an update to a new major version was found.

The 2 new checks mentioned above are performed with that new step. If any of the test fails, an error message is shown with the (translated) plugin name, a final message tells that the conditions are not fulfilled, and the update is not performed.

If both checks succeed, the update is performed by the CLI.

If the update which was found is not an upgrade to a new major version, the 2 nex checks are not shown in the pre-update check, and in the CLI the new step for checking the pre-conditions of a major upgrade is not executed.

1. Both plugins enabled

2. Joomla 5 plugin enabled and Joomla 6 plugin disabled

3. Both plugins disabled

4. Joomla 5 plugin disabled and Joomla 6 plugin enabled

Test 2: Update to 5.4 nightly build

When an update has been found which is not an upgrade to a new major version, the new checks are not shown in the pre-update check, and in the CLI update the new step for checking the pre-requisites is not executed, i.e. everything works the same as without this PR.

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed