[#45489] - Add missing visually-hidden menu title in image menu
- Closed
- 16 May 2025
- Medium
- Build: 5.3-dev
- # 45489
- Diff
- drmenzelit:image-menu
User tests: Successful: Unsuccessful:
Summary of Changes
Add missing visually-hidden menu title in menu items of type "heading" and "separator" when using an image without text
The changes are done for the standard menu and for the Metismenu in Cassiopeia.
Testing Instructions
- Create a menu item of type "single article", select an image for the menu and set "Display Menu Item Title" to no
- Create a menu item of type "heading" and / or "separator"with the same configuration
Actual result BEFORE applying this Pull Request
The menu item of type "single article" display the image and the title of the menu as a span element visually hidden
The menu item of type "heading" and / or "separator" show the image, but the title is missing
Expected result AFTER applying this Pull Request
The menu items of type "heading" and "separator" have also a visually-hidden title.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository SQL Administration com_admin Postgresql com_associations com_banners com_categories com_config com_contact com_content com_fields com_finder com_installer |
Not directly, in Cassiopeia the vertical / horizontal line for the separator is created with CSS
I see it different.
There are two types of menu items - headings and separators - which are not links.
For headings we use the item title as visually-hidden infomation for blind users. This sounds good. But there is only an image and no text, there is no guarantee that this information makes sense.
For separators we don't give any information for blind users. If there the separator is an image with a meaning, there is no chance to add it.
As a consequence we should think about alt-texts for images in menu-items.
And we should think about cleaning the code of these four types for menu-items, which are mostly copies of the same code.
I will rework it. Closing for the moment.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-05-16 18:11:42 |
| Closed_By | ⇒ | drmenzelit | |
| Labels |
Added:
a11y
PR-5.4-dev
|
||
| Category | Repository SQL Administration com_admin Postgresql com_associations com_banners com_categories com_config com_contact com_content com_fields com_finder com_installer | ⇒ | Modules Front End Templates (site) |
Possible related issue #41102