[#45460] - [5.4] Add tag filter none com_newsfeeds
- Fixed in Code Base
- 20 May 2025
- Medium
- Build: 5.4-dev
- # 45460
- Diff
- brianteeman:newsfeed_tag_none
User tests: Successful: Unsuccessful:
The aim of this PR is to add a new filter option when filtering for tags that allows you to filter all newsfeeds that have no tags at all.
This is only for com_newsfeeds (articles and featured articles already done with #45274)
To test create four newsfeeds
Newsfeed 1 no tags
Newsfeed 2 taga
Newsfeed 3 3 tagb
Newsfeed 4 taga and tagb
Using the filter check that the filter works correctly when selecting any of the tags AND/OR items with no tags (None)
You should be able to filter the newsfeeds on any single tag or combination of tags AND filter the contacts with no tags and any single tag or combination of tags
Thanks to @richard67 for the query
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_newsfeeds |
| Labels |
Added:
PR-5.4-dev
|
||
@brianteeman No, it's a hard-coded string and nothing from input, so no need for a bind variable here. See also where it is not modified by this PR: https://github.com/joomla/joomla-cms/pull/45460/files#diff-38c1de4d15fa0ac13f1c64c411eda1ae91777431a00ca4a6ba2a2e906f9c1138R337
I was prompted to ask the question when I saw
never mind I can see com_categories is different
never mind I can see why com_categories is different
never mind I can see why com_categories is different
Yes, cause there the code is used for different contexts (type aliases).
I have tested this item ✅ successfully on b905a3f
I have tested this successfully just like for com_contact.
Works as expected: None, TagA, TagB, TagA+TagB, None+TagA, None+TagB, None+TagA+TagB :)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45460.
I have tested this item ✅ successfully on b905a3f
I have tested this PR, works as expected!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45460.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45460.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-05-20 04:41:04 |
| Closed_By | ⇒ | muhme |
Thank you all for your contribution.
thanks
@richard67 I know this was your query but I wonder if it should be changed
from
$db->quoteName('tagmap.type_alias') . ' = ' . $db->quote('com_newsfeeds.newsfeed'),to
$db->quoteName('tagmap.type_alias') . ' = :typeAlias',