[#45445] - [5.3] Limit length of searchterm logging to prevent MysqliStatement error
- Fixed in Code Base
- 12 May 2025
- Medium
- Build: 5.3-dev
- # 45445
- Diff
- Attila-SWE:patch-2
User tests: Successful: Unsuccessful:
Summary of Changes
Limit searchterm input to match database table limitations. Currently #_finder_logging has searchterm length of 255. I see (spambot?) searches with massive lengths that creates errors.
Testing Instructions
Go to
component/finder/search?Itemid=101&Itemid=101&q=harry+potter+at+hogwarts+if+ernie+introduced+himself+to+hannah+they+are+both+in+their+first+year+they+are+both+in+the+hufflepuff+common+room+after+the+sorting+on+the+night+before+classes+start+the+next+day+she+warmly+shakes+his+hand+he+is+very+nervous+she+patiently+listens+to+his+worries+and+she+helps+him+relax+as+they+discuss+the+next+seven+years+at+hogwarts+scene+and+dialogue
(yes... real search in error log)
Actual result BEFORE applying this Pull Request
Error page and
libraries/vendor/joomla/database/src/Mysqli/MysqliStatement.php:::411:::Data too long for column 'searchterm' at row 1
Expected result AFTER applying this Pull Request
Search page showing correctly but with trimmed search to 255 characters.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_finder |
As this is only relevant when Gather Search Statistics is on and this only truncates the data saved in the #__finder_logging table can you please rename this PR to reflect that.
Perhaps
[5.3] Limit length of searchterm logging to prevent MysqliStatement error
I have tested this item ✅ successfully on 62e1e31
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45445.
| Title |
|
||||||
I have tested this item ✅ successfully on 62e1e31
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45445.
@Attila-SWE I have removed your test as obviously we assume that you submit tested code ;)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45445.
I have tested this item ✅ successfully on 62e1e31
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45445.
Am I as Pull Requester supposed to also check that I have tested this item successfully or is the point that 2 other persons should check this and that I as pull requester by default have tested successfully?
@Attila-SWE I have removed your test as obviously we assume that you submit tested code ;)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45445.
Thanks! I just wrote question about it! Understood.
I have tested this item ✅ successfully on 62e1e31
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45445.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-5.3-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45445.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-05-12 14:21:58 |
| Closed_By | ⇒ | rdeutz |
When testing this make sure you set Gather Search Statistics in the component options to yes