User tests: Successful: Unsuccessful:
Allow update server administrator to return a message to the Joomla admin.
Pull Request for Issue # .
Add a preupdatemessage field to the XML returned by the update server.
Install test plugin:
https://www.brainforge.co.uk/media/extra_downloads/test/test.zip
Check for updates and the test plugin will appear.
Tick the box and run update.
In this example a simple error message will appear and the update aborted.
... a warning / information message could been used instead.
Update works as expected - although the version number is unchanged!
So it only temporarily disappears from the available update list.
Error message displayed and the update does not happen.
The benefit of this is that an update server manager can send a message to the Joomla administrator.
e.g. 'Please contact us.'
The following documentation requires updating:
https://manual.joomla.org/docs/building-extensions/install-update/update-server/
See file: https://www.brainforge.co.uk/media/extra_downloads/test/updatetest.xml
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_installer |
Labels |
Added:
PR-5.3-dev
|
Title |
|
I would like to see a strip_tags being applied to the message, to make sure that devs don't start to inject HTML tags into those messages -> XSS
Labels |
Added:
Feature
|
Good idea adding strip_tags.
Also added message to avoid a silent failure.
Please fix phpcs: https://ci.joomla.org/joomla/joomla-cms/84617/1/7
As it's a new feature it can't go into 5.3-dev. It has to be moved to either 5.4-dev or 6.0-dev. We discuss that and come back with a decision.
I suggest 5.4-dev as too much else going on with 6.0.dev
Please fix phpcs: https://ci.joomla.org/joomla/joomla-cms/84551/1/7