[#45424] - [5.3] Delete unused build tools file scss-transform.mjs
- Fixed in Code Base
- 12 May 2025
- Medium
- Build: 5.3-dev
- # 45424
- Diff
- dgrammatiko:staging
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- The file is not used anywhere anymore so it could be safely removed
Testing Instructions
- Do a search for
import { compile }in the build folder, should return 0 results - Do a search for
compilein the build tools, no results should have something likeimport ...that referring to the deleted filebuild/build-modules-js/stylesheets/scss-transform.mjs
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
@richard67 ping
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository |
@richard67 sorry, wrong rm I guess
@richard67 sorry, wrong rm I guess
@dgrammatiko 5.3 Doesn’t have an RM, so it’s the maintainers team managing that release. I am one of 2 RMs for 5.4 and also in the maintainers team. So your ping was not completely wrong, just I did not know the reason.
Can we also remove them some dev dependencies like lightning?
Not in this pr
I have tested this item ✅ successfully on fa67ba5
compile import is not found and cms can be built fully with npm ci
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45424.
I have tested this item ✅ successfully on fa67ba5
I've run a php ./build/build.php --remote=HEAD --exclude-gzip --exclude-zstd without and with this PR and have verified the results (full installation zip packages) and the output on the command line. I haven't found any unexpected differences.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45424.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-5.3-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45424.
| Labels |
Added:
RTC
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-05-12 12:54:06 |
| Closed_By | ⇒ | rdeutz |
@dgrammatiko Why this? The file is in the build folder and so not part of any installation or update package and so does not need to be deleted on update. So I have no idea why you ping me.