Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#45420] - [5.3] Installer rtl logical css

RTC NPM Resource Changed PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
1 May 2025

At some point in time a change was made and the post scss rtlcss started processing the installation template scss files so it was actually reversing everything - doh - so any directives in the current rtl-scss were being reverted by rtlcss

Summary of Changes

Made sure the installation template uses logical css properties (-start, -end instead of -left, -right)
Fixed the css generation so that the rtlcss now works as intended - thanks @dgrammatiko
Removed all overrides from template-rtl,scss as they are not needed with logical css and a working rtlcss processing

Testing Instructions

Apply pr and npm run build:css or use a pre-built package
Check everything "looks" ok in both LTR and RTL languages

Actual result BEFORE applying this Pull Request

before

Expected result AFTER applying this Pull Request

after

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 1 May 2025
avatar brianteeman brianteeman - change - 1 May 2025
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 May 2025
Category ⇒ Installation NPM Change
avatar brianteeman brianteeman - change - 1 May 2025
The description was changed
avatar brianteeman brianteeman - edited - 1 May 2025
avatar brianteeman brianteeman - change - 1 May 2025
Labels Added: NPM Resource Changed PR-5.3-dev
avatar brianteeman brianteeman - change - 1 May 2025
The description was changed
avatar brianteeman brianteeman - edited - 1 May 2025
avatar joomla-cms-bot joomla-cms-bot - change - 1 May 2025
Category Installation NPM Change ⇒ JavaScript Repository Installation NPM Change
avatar brianteeman brianteeman - change - 1 May 2025
Title
…
DRAFT Installer rtl logical css
[5.2] Installer rtl logical css
avatar brianteeman brianteeman - edited - 1 May 2025
avatar brianteeman brianteeman - change - 1 May 2025
The description was changed
avatar brianteeman brianteeman - edited - 1 May 2025
avatar brianteeman brianteeman - change - 1 May 2025
Title
…
[5.2] Installer rtl logical css
[5.3] Installer rtl logical css
avatar brianteeman brianteeman - edited - 1 May 2025
avatar dgrammatiko
dgrammatiko - comment - 2 May 2025

@brianteeman please remove these lines, (belong to another PR)

const silenceDeprecationList = [


   `media_source${sep}templates`,
   `installation${sep}template`,
   `media_source${sep}plg_installer_webinstaller`,
   `vendor${sep}fontawesome-free`,
   `media_source${sep}system${sep}scss${sep}joomla-fontawesome.scss`,
   `media_source${sep}com_media`,
   `media_source${sep}plg_system_guidedtours${sep}scss${sep}guidedtours.scss`,
 ];
 const shouldSilenceDeprecation = (file) => silenceDeprecationList.some((path) => new RegExp(String.raw`${path}`, 'i').test(file));
  const options = shouldSilenceDeprecation(file) ? { silenceDeprecations: ['mixed-decls', 'color-functions', 'import', 'global-builtin'] } : {};

and change const { css } = await compileAsync(file, options); to const { css } = await compileAsync(file);

avatar brianteeman
brianteeman - comment - 2 May 2025

@brianteeman please remove these lines, (belong to another PR)

done

avatar QuyTon QuyTon - test_item - 3 May 2025 - Tested successfully
avatar QuyTon
QuyTon - comment - 3 May 2025

I have tested this item ✅ successfully on 151e865

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45420.

avatar brianteeman brianteeman - change - 5 May 2025
The description was changed
avatar brianteeman brianteeman - edited - 5 May 2025
avatar dgrammatiko dgrammatiko - test_item - 7 May 2025 - Tested successfully
avatar dgrammatiko
dgrammatiko - comment - 7 May 2025

I have tested this item ✅ successfully on 151e865

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45420.

avatar alikon alikon - change - 7 May 2025
Status Pending ⇒ Ready to Commit
avatar alikon
alikon - comment - 7 May 2025

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45420.

avatar QuyTon QuyTon - change - 7 May 2025
Labels Added: RTC
avatar brianteeman
brianteeman - comment - 11 May 2025

I would appreciate it if this could be merged as I have several PR waiting the changes to the RTL tooling that are contained in this PR

avatar HLeithner HLeithner - change - 12 May 2025
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2025-05-12 10:25:49
Closed_By ⇒ HLeithner
avatar HLeithner HLeithner - close - 12 May 2025
avatar HLeithner HLeithner - merge - 12 May 2025
avatar brianteeman
brianteeman - comment - 12 May 2025

thanks

Add a Comment

Login with GitHub to post a comment